fix: correct summarizer typos and wire dead web search fallback route#157
Open
bhavyakeerthi3 wants to merge 3 commits intoreactome:mainfrom
Open
fix: correct summarizer typos and wire dead web search fallback route#157bhavyakeerthi3 wants to merge 3 commits intoreactome:mainfrom
bhavyakeerthi3 wants to merge 3 commits intoreactome:mainfrom
Conversation
Fixed multiple typos ('adn' -> 'and', 'infromation' -> 'information',
'retining' -> 'retaining', 'drived' -> 'derived') and corrected the
broken numbering sequence in the expert curator system prompt.
Clean and professional prompts improve the LLM's adherence to
instructions and overall response quality.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🐛Summary
Surgical hardening of the
CrossDatabaseagent: fixes pre-existing typos in the summarization prompt and resolves a silent "dead route" where web search decisions were never executed.Changes
1. Prompt Improvements & Typo Fixes
src/agent/tasks/cross_database/summarize_reactome_uniprot.pyADN→and,infromation→information)2. Wiring the Web Search Fallback
src/agent/profiles/cross_database.pyThe Issue:
The
perform_web_searchroute was hardcoded to point directly togenerate_final_response— the agent would decide to search but skip execution entirely, producing incomplete responses.The Fix:
web_search_resultstoCrossDatabaseStateperform_web_searchnode using the existingsearch_workflowassess_completeness→perform_web_search→generate_final_responseImpact
Verification
CrossDatabaseStatecorrectly holdsweb_search_resultsassess_completeness→perform_web_search→generate_final_responsetests/test_config.pypassingFixes #123