Skip to content

Lesson 01 - Fix bug when key is held down #468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
russellSE16 wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Lesson 01 - Fix bug when key is held down #468

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5a65871
Fix bug when key is held down by preventing playSound running again u…
russellSE16 Jul 2, 2021
d5f9ef0
Bug fix prevented two different keys being played together - fix to p…
russellSE16 Jul 2, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions 01 - JavaScript Drum Kit/index-FINISHED.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,24 +58,30 @@
<audio data-key="76" src="sounds/tink.wav"></audio>

<script>
let justPlayed = null;

function removeTransition(e) {
if (e.propertyName !== 'transform') return;
e.target.classList.remove('playing');
}

function playSound(e) {
if (e.keyCode === justPlayed) return; // If same key has just been played without key being released, don't play again

const audio = document.querySelector(`audio[data-key="${e.keyCode}"]`);
const key = document.querySelector(`div[data-key="${e.keyCode}"]`);
if (!audio) return;

key.classList.add('playing');
audio.currentTime = 0;
audio.play();
justPlayed = e.keyCode; // Set the key that has just been played
}

const keys = Array.from(document.querySelectorAll('.key'));
keys.forEach(key => key.addEventListener('transitionend', removeTransition));
window.addEventListener('keydown', playSound);
window.addEventListener('keyup', () => justPlayed = null); // Allow key to be played again
</script>


Expand Down