Lesson 01 - Fix bug when key is held down#468
Open
russellSE16 wants to merge 2 commits intowesbos:masterfrom
Open
Lesson 01 - Fix bug when key is held down#468russellSE16 wants to merge 2 commits intowesbos:masterfrom
russellSE16 wants to merge 2 commits intowesbos:masterfrom
Conversation
…revent only same key being played again until keyup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the bug where if the key is held down the 'playing' class doesn't get removed. It does so by adding some lines to prevent the sound being played a second time until the same key is released. This also feels more intuitive as holding down a key doesn't make the sound play repeatedly, you must press the key repeatedly to do that.