fix: clear errors for missing embeddings and S3 403 (#114)#159
Open
mithil27360 wants to merge 1 commit intoreactome:mainfrom
Open
fix: clear errors for missing embeddings and S3 403 (#114)#159mithil27360 wants to merge 1 commit intoreactome:mainfrom
mithil27360 wants to merge 1 commit intoreactome:mainfrom
Conversation
- Add EmbeddingEnvironment.get_dir_or_raise() to raise RuntimeError with install instructions instead of returning None - Update retriever call sites to use get_dir_or_raise() - Catch botocore ClientError in pull() and ls_remote() with human-readable messages for 403 and NoSuchKey errors Fixes reactome#114
Author
|
Hi, I've opened a PR that addresses both issues described here. PR: #159 Happy to make any changes if the approach needs adjustment. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #114