fix: wire AgentGraph to YAML config#151
Open
bhavyakeerthi3 wants to merge 2 commits intoreactome:mainfrom
Open
fix: wire AgentGraph to YAML config#151bhavyakeerthi3 wants to merge 2 commits intoreactome:mainfrom
bhavyakeerthi3 wants to merge 2 commits intoreactome:mainfrom
Conversation
Updated the Config Pydantic model and YAML schema to include llm and embedding fields. Modified AgentGraph constructor to accept these configurations and updated the chat-chainlit.py entry point to pass them from the loaded configuration. This removes hardcoded 'gpt-4o-mini' and 'text-embedding-3-large' references, making the agent models fully configurable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #108
Closes #148
Description
This PR addresses the long-standing issue where
AgentGraphhardcoded the LLM and embedding models, ignoring any settings inconfig.yml.First reported in #108, this completes the YAML configurability work by extending it to the most critical parameters.
Changes
llmandembeddingfields toConfiginsrc/util/config_yml/__init__.py.config.schema.yamlandconfig_default.ymlwith safe defaultsAgentGraphconstructor to accept model configs instead of hardcoded stringschat-chainlit.pyto pass YAML-loaded configs to the agentTests Added
Relation to Other PRs
Completes configurability work started in #112 by AaryanCode69, extending it to cover LLM and embedding model parameters which were not included in that PR.