Skip to content

chore(deps): bump dit to v0.0.24#2500

Merged
Mzack9999 merged 1 commit into
devfrom
chore/bump-dit-0.0.24
May 20, 2026
Merged

chore(deps): bump dit to v0.0.24#2500
Mzack9999 merged 1 commit into
devfrom
chore/bump-dit-0.0.24

Conversation

@dogancanbakir
Copy link
Copy Markdown
Member

@dogancanbakir dogancanbakir commented May 20, 2026

Fixes #2495

Summary by CodeRabbit

  • Chores
    • Updated dependency to the latest version for improved stability and performance.

Review Change Stack

@auto-assign auto-assign Bot requested a review from Mzack9999 May 20, 2026 11:00
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 20, 2026

Walkthrough

The go.mod file is updated to pin github.com/happyhackingspace/dit to version v0.0.24, incrementing from the previous version v0.0.23. This is a single-line dependency version update with no changes to other modules or Go directives.

Changes

Dependency Update

Layer / File(s) Summary
dit module version bump
go.mod
The github.com/happyhackingspace/dit dependency is updated from v0.0.23 to v0.0.24.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

A version bump, so small and neat,
dit now rises to v0.0.24 complete,
Filters flow and errors fly,
Our little rabbit cheers on high! 🐰

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The PR title 'chore(deps): bump dit to v0.0.24' accurately describes the main change in the changeset - updating the dit dependency to v0.0.24.
Linked Issues check ✅ Passed The PR updates dit to v0.0.24 to fix the -fpt error filtering issue reported in #2495, aligning with the stated objective of restoring correct filtering behavior.
Out of Scope Changes check ✅ Passed The PR contains only a single, focused change - updating the dit dependency version in go.mod, which is directly scoped to fixing the linked issue.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/bump-dit-0.0.24

Comment @coderabbitai help to get the list of available commands and usage tips.

@dogancanbakir dogancanbakir self-assigned this May 20, 2026
Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@go.mod`:
- Line 57: The dependency entry "github.com/happyhackingspace/dit v0.0.24" in
go.mod does not appear to contain the `#2495` fix; confirm the correct upstream
release that includes the fix by checking the repository tags/PRs for the commit
that implements issue `#2495`, then update go.mod to reference that exact tag or
commit (or add a replace directive) so the project uses the release containing
the fix; look for the module name "github.com/happyhackingspace/dit" and change
the version string to the confirmed tag/commit or coordinate with the upstream
maintainer if no such release exists.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: ce99bd83-fbe3-4d87-9c75-385199b3f235

📥 Commits

Reviewing files that changed from the base of the PR and between d0081af and 41501ff.

⛔ Files ignored due to path filters (1)
  • go.sum is excluded by !**/*.sum
📒 Files selected for processing (1)
  • go.mod

Comment thread go.mod
github.com/go-viper/mapstructure/v2 v2.5.0
github.com/gocarina/gocsv v0.0.0-20240520201108-78e41c74b4b1
github.com/happyhackingspace/dit v0.0.23
github.com/happyhackingspace/dit v0.0.24
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
set -euo pipefail

echo "1) Confirm module bump is reflected in go.mod/go.sum"
rg -n 'github.com/happyhackingspace/dit' go.mod go.sum || true

echo
echo "2) Locate where dit is used in this repo (for impact surface)"
rg -n --type=go 'happyhackingspace/dit|\\bdit\\b' -C2

echo
echo "3) Inspect upstream compare for v0.0.23...v0.0.24"
# If repo is public, this should return changed commits/files between tags
curl -sL 'https://api.github.com/repos/happyhackingspace/dit/compare/v0.0.23...v0.0.24' \
  | jq '{status, ahead_by, total_commits, files: [.files[]?.filename], commits: [.commits[]?.commit.message]}'

echo
echo "4) Check for fix-related terms in upstream compare payload"
curl -sL 'https://api.github.com/repos/happyhackingspace/dit/compare/v0.0.23...v0.0.24' \
  | jq -r '.commits[]?.commit.message, .files[]?.filename' \
  | rg -n -i 'error|filter|fpt|page|regression|2495' || true

echo
echo "Manual final check requested from author/reviewer:"
echo "- Run the exact reproduction from issue `#2495` against this PR build and attach output."

Repository: projectdiscovery/httpx

Length of output: 1427


v0.0.24 does not appear to include the #2495 fix—verify version or find the correct upstream release.

The upstream compare for v0.0.23...v0.0.24 shows 3 commits focused on model auto-downloading and timeout handling, with no mention of error filtering, -fpt regression, or issue #2495. The changed files (dit.go, internal/cli/run.go, internal/cli/up.go) and commit messages ("auto-download model in dit.New()", "add download timeout") are unrelated to the stated PR goal of restoring -fpt error behavior.

Confirm with the upstream maintainer that v0.0.24 actually includes the #2495 fix, or identify and use the correct release tag.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@go.mod` at line 57, The dependency entry "github.com/happyhackingspace/dit
v0.0.24" in go.mod does not appear to contain the `#2495` fix; confirm the correct
upstream release that includes the fix by checking the repository tags/PRs for
the commit that implements issue `#2495`, then update go.mod to reference that
exact tag or commit (or add a replace directive) so the project uses the release
containing the fix; look for the module name "github.com/happyhackingspace/dit"
and change the version string to the confirmed tag/commit or coordinate with the
upstream maintainer if no such release exists.

@Mzack9999 Mzack9999 merged commit 41e6d9b into dev May 20, 2026
13 checks passed
@Mzack9999 Mzack9999 deleted the chore/bump-dit-0.0.24 branch May 20, 2026 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

-fpt error does not work in v1.9.0

2 participants