Skip to content

chore(deps): bump dit to v0.0.24 #2500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Mzack9999 merged 1 commit into from
May 20, 2026
+3 −3
Merged

chore(deps): bump dit to v0.0.24 #2500

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ require (
github.com/go-sql-driver/mysql v1.10.0
github.com/go-viper/mapstructure/v2 v2.5.0
github.com/gocarina/gocsv v0.0.0-20240520201108-78e41c74b4b1
github.com/happyhackingspace/dit v0.0.23
github.com/happyhackingspace/dit v0.0.24
Copy link
Copy Markdown

@coderabbitai coderabbitai Bot May 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
set -euo pipefail

echo "1) Confirm module bump is reflected in go.mod/go.sum"
rg -n 'github.com/happyhackingspace/dit' go.mod go.sum || true

echo
echo "2) Locate where dit is used in this repo (for impact surface)"
rg -n --type=go 'happyhackingspace/dit|\\bdit\\b' -C2

echo
echo "3) Inspect upstream compare for v0.0.23...v0.0.24"
# If repo is public, this should return changed commits/files between tags
curl -sL 'https://api.github.com/repos/happyhackingspace/dit/compare/v0.0.23...v0.0.24' \
  | jq '{status, ahead_by, total_commits, files: [.files[]?.filename], commits: [.commits[]?.commit.message]}'

echo
echo "4) Check for fix-related terms in upstream compare payload"
curl -sL 'https://api.github.com/repos/happyhackingspace/dit/compare/v0.0.23...v0.0.24' \
  | jq -r '.commits[]?.commit.message, .files[]?.filename' \
  | rg -n -i 'error|filter|fpt|page|regression|2495' || true

echo
echo "Manual final check requested from author/reviewer:"
echo "- Run the exact reproduction from issue `#2495` against this PR build and attach output."

Repository: projectdiscovery/httpx

Length of output: 1427

v0.0.24 does not appear to include the #2495 fix—verify version or find the correct upstream release.

The upstream compare for v0.0.23...v0.0.24 shows 3 commits focused on model auto-downloading and timeout handling, with no mention of error filtering, -fpt regression, or issue #2495. The changed files (dit.go, internal/cli/run.go, internal/cli/up.go) and commit messages ("auto-download model in dit.New()", "add download timeout") are unrelated to the stated PR goal of restoring -fpt error behavior.

Confirm with the upstream maintainer that v0.0.24 actually includes the #2495 fix, or identify and use the correct release tag.

🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@go.mod` at line 57, The dependency entry "github.com/happyhackingspace/dit
v0.0.24" in go.mod does not appear to contain the `#2495` fix; confirm the correct
upstream release that includes the fix by checking the repository tags/PRs for
the commit that implements issue `#2495`, then update go.mod to reference that
exact tag or commit (or add a replace directive) so the project uses the release
containing the fix; look for the module name "github.com/happyhackingspace/dit"
and change the version string to the confirmed tag/commit or coordinate with the
upstream maintainer if no such release exists.

github.com/lib/pq v1.12.3
github.com/projectdiscovery/awesome-search-queries v0.0.0-20260104120501-961ef30f7193
github.com/seh-msft/burpxml v1.0.1
Expand Down
4 changes: 2 additions & 2 deletions go.sum
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,8 +206,8 @@ github.com/gosimple/slug v1.15.0 h1:wRZHsRrRcs6b0XnxMUBM6WK1U1Vg5B0R7VkIf1Xzobo=
github.com/gosimple/slug v1.15.0/go.mod h1:UiRaFH+GEilHstLUmcBgWcI42viBN7mAb818JrYOeFQ=
github.com/gosimple/unidecode v1.0.1 h1:hZzFTMMqSswvf0LBJZCZgThIZrpDHFXux9KeGmn6T/o=
github.com/gosimple/unidecode v1.0.1/go.mod h1:CP0Cr1Y1kogOtx0bJblKzsVWrqYaqfNOnHzpgWw4Awc=
github.com/happyhackingspace/dit v0.0.23 h1:hW/PxrLOjx4T9Z45WNVj4IHnoFkSULqk4RNvbHVQClc=
github.com/happyhackingspace/dit v0.0.23/go.mod h1:bpI1nXCAB8/E4t0GYSu8I4uYmJKMlxFqf1D+jq5i02Y=
github.com/happyhackingspace/dit v0.0.24 h1:0zVQ6VPfBwDSed/Vkni9PGUc0qe5WEYyYQh1G8ewqb4=
github.com/happyhackingspace/dit v0.0.24/go.mod h1:bpI1nXCAB8/E4t0GYSu8I4uYmJKMlxFqf1D+jq5i02Y=
github.com/hashicorp/go-version v1.8.0 h1:KAkNb1HAiZd1ukkxDFGmokVZe1Xy9HG6NUp+bPle2i4=
github.com/hashicorp/go-version v1.8.0/go.mod h1:fltr4n8CU8Ke44wwGCBoEymUuxUHl09ZGVZPK5anwXA=
github.com/hashicorp/golang-lru v0.5.0/go.mod h1:/m3WP610KZHVQ1SGc6re/UDhFvYD7pJ4Ao+sR/qLZy8=
Expand Down
Loading