Skip to content

ci(integration): bump Dagger Go base image to 1.25-alpine#241

Merged
beeme1mr merged 2 commits intoopen-feature:mainfrom
professorice:fix/integration-test-go-1.25
Apr 28, 2026
Merged

ci(integration): bump Dagger Go base image to 1.25-alpine#241
beeme1mr merged 2 commits intoopen-feature:mainfrom
professorice:fix/integration-test-go-1.25

Conversation

@professorice
Copy link
Copy Markdown
Contributor

Summary

The Dagger integration test containers and the new-generator example documentation pin the Go base image to golang:1.24-alpine, but go.mod requires go >= 1.25.0. As a result, the Generator Integration Tests workflow fails on every PR with:

go: go.mod requires go >= 1.25.0 (running go 1.24.13; GOTOOLCHAIN=local)

This affects every open PR — including the maintainers' own release PR (#234) — because the CLI is rebuilt inside the 1.24 container during the C#, Node.js, Angular, and Go integration runs.

This change bumps the base image to golang:1.25-alpine in:

  • test/integration/cmd/csharp/run.go
  • test/integration/cmd/nodejs/run.go
  • test/integration/cmd/angular/run.go
  • test/integration/cmd/go/run.go (2 occurrences — CLI build container and Go fixture compile container)
  • test/new-generator.md (the documented example for adding a new generator)

The toolchain go1.24.1 line in test/go-integration/go.mod is a minimum-toolchain directive and still satisfied by Go 1.25, so it is left alone.

Test plan

  • go build ./... succeeds
  • go test ./... passes
  • make ci passes locally (fmt, lint, test, verify-generate)
  • Generator Integration Tests pass in CI on this PR (the actual smoke test)

Made with Cursor

The integration test containers (csharp, nodejs, angular, go) and the
new-generator example documentation pin the Dagger base image to
golang:1.24-alpine, but the project's go.mod requires go >= 1.25.0.

This causes the Generator Integration Tests workflow to fail on every
PR with:

    go: go.mod requires go >= 1.25.0 (running go 1.24.13; GOTOOLCHAIN=local)

Bump the base image to golang:1.25-alpine across all four integration
runners and the documentation example to match go.mod and unblock CI.

Signed-off-by: Menelik Zafir <mzafir@launchdarkly.com>
Made-with: Cursor
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the Go base image version from 1.24-alpine to 1.25-alpine across multiple integration test files and documentation. The review feedback highlights opportunities to improve maintainability by centralizing the hardcoded version string and base container setup into shared constants or variables, reducing redundancy across the test suite.

Comment thread test/integration/cmd/angular/run.go Outdated
Comment thread test/integration/cmd/go/run.go Outdated
Per review feedback, replace the hardcoded golang:1.25-alpine string
with a single integration.GoBaseImage constant and reference it from
all runners (csharp, nodejs, angular, go) and the new-generator
documentation. Future Go version bumps now happen in one place.

Within test/integration/cmd/go/run.go, factor the duplicated
"golang base + apk add git" setup into a goBase() helper used by
both the CLI build container and the generated-client compile
container.

Signed-off-by: Menelik Zafir <mzafir@launchdarkly.com>
Made-with: Cursor
@beeme1mr beeme1mr added this pull request to the merge queue Apr 28, 2026
Merged via the queue into open-feature:main with commit 6dfe0da Apr 28, 2026
7 checks passed
beeme1mr added a commit that referenced this pull request Apr 28, 2026
PR #241 bumped the Dagger integration runners to Go 1.25 via a
centralized integration.GoBaseImage constant, but left the secondary
test/go-integration/go.mod and the contributor docs still pinned to
the previous minimum. Update those for consistency with go.mod's
go 1.25.0 floor.

Signed-off-by: Michael Beemer <beeme1mr@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants