ci(integration): bump Dagger Go base image to 1.25-alpine#241
Merged
beeme1mr merged 2 commits intoopen-feature:mainfrom Apr 28, 2026
Merged
ci(integration): bump Dagger Go base image to 1.25-alpine#241beeme1mr merged 2 commits intoopen-feature:mainfrom
beeme1mr merged 2 commits intoopen-feature:mainfrom
Conversation
The integration test containers (csharp, nodejs, angular, go) and the
new-generator example documentation pin the Dagger base image to
golang:1.24-alpine, but the project's go.mod requires go >= 1.25.0.
This causes the Generator Integration Tests workflow to fail on every
PR with:
go: go.mod requires go >= 1.25.0 (running go 1.24.13; GOTOOLCHAIN=local)
Bump the base image to golang:1.25-alpine across all four integration
runners and the documentation example to match go.mod and unblock CI.
Signed-off-by: Menelik Zafir <mzafir@launchdarkly.com>
Made-with: Cursor
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the Go base image version from 1.24-alpine to 1.25-alpine across multiple integration test files and documentation. The review feedback highlights opportunities to improve maintainability by centralizing the hardcoded version string and base container setup into shared constants or variables, reducing redundancy across the test suite.
Per review feedback, replace the hardcoded golang:1.25-alpine string with a single integration.GoBaseImage constant and reference it from all runners (csharp, nodejs, angular, go) and the new-generator documentation. Future Go version bumps now happen in one place. Within test/integration/cmd/go/run.go, factor the duplicated "golang base + apk add git" setup into a goBase() helper used by both the CLI build container and the generated-client compile container. Signed-off-by: Menelik Zafir <mzafir@launchdarkly.com> Made-with: Cursor
sahidvelji
approved these changes
Apr 27, 2026
beeme1mr
approved these changes
Apr 28, 2026
beeme1mr
added a commit
that referenced
this pull request
Apr 28, 2026
PR #241 bumped the Dagger integration runners to Go 1.25 via a centralized integration.GoBaseImage constant, but left the secondary test/go-integration/go.mod and the contributor docs still pinned to the previous minimum. Update those for consistency with go.mod's go 1.25.0 floor. Signed-off-by: Michael Beemer <beeme1mr@users.noreply.github.com>
This was referenced Apr 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Dagger integration test containers and the new-generator example documentation pin the Go base image to
golang:1.24-alpine, butgo.modrequiresgo >= 1.25.0. As a result, the Generator Integration Tests workflow fails on every PR with:This affects every open PR — including the maintainers' own release PR (#234) — because the CLI is rebuilt inside the 1.24 container during the C#, Node.js, Angular, and Go integration runs.
This change bumps the base image to
golang:1.25-alpinein:test/integration/cmd/csharp/run.gotest/integration/cmd/nodejs/run.gotest/integration/cmd/angular/run.gotest/integration/cmd/go/run.go(2 occurrences — CLI build container and Go fixture compile container)test/new-generator.md(the documented example for adding a new generator)The
toolchain go1.24.1line intest/go-integration/go.modis a minimum-toolchain directive and still satisfied by Go 1.25, so it is left alone.Test plan
go build ./...succeedsgo test ./...passesmake cipasses locally (fmt, lint, test, verify-generate)Made with Cursor