chore: align remaining Go 1.25 references in docs and test go.mod#242
Merged
chore: align remaining Go 1.25 references in docs and test go.mod#242
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the project's Go version requirement to 1.25 across the documentation, module files, and integration test environments. Additionally, it includes a significant cleanup of the go.sum file by removing redundant or older dependency versions. I have no feedback to provide as there were no review comments to evaluate.
sahidvelji
approved these changes
Apr 28, 2026
PR #241 bumped the Dagger integration runners to Go 1.25 via a centralized integration.GoBaseImage constant, but left the secondary test/go-integration/go.mod and the contributor docs still pinned to the previous minimum. Update those for consistency with go.mod's go 1.25.0 floor. Signed-off-by: Michael Beemer <beeme1mr@users.noreply.github.com>
53948e7 to
ec1d976
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PR #241 centralized the Dagger integration test Go image into an
integration.GoBaseImageconstant and bumped it togolang:1.25-alpine. That left a few stragglers untouched, all of which still reference older Go versions:test/go-integration/go.mod— still pinned togo 1.23.0with atoolchain go1.24.1directiveREADME.md—Go >= 1.23install prerequisiteCONTRIBUTING.md—Go 1.23 or laterdevelopment prerequisiteThis PR brings them in line with
go.mod'sgo 1.25.0floor. The secondary go.mod drops itstoolchaindirective to match the main module.go.sumalso gets the orphan-entry cleanup that was missed by the original Renovate bump.Test plan
make cipasses locally (fmt, lint, unit tests, generated-files check)cd test/go-integration && go build ./...succeeds against the bumped go.mod