Skip to content

chore: align remaining Go 1.25 references in docs and test go.mod#242

Merged
beeme1mr merged 1 commit intomainfrom
chore/bump-go-1.25
Apr 28, 2026
Merged

chore: align remaining Go 1.25 references in docs and test go.mod#242
beeme1mr merged 1 commit intomainfrom
chore/bump-go-1.25

Conversation

@beeme1mr
Copy link
Copy Markdown
Member

@beeme1mr beeme1mr commented Apr 28, 2026

Summary

PR #241 centralized the Dagger integration test Go image into an integration.GoBaseImage constant and bumped it to golang:1.25-alpine. That left a few stragglers untouched, all of which still reference older Go versions:

  • test/go-integration/go.mod — still pinned to go 1.23.0 with a toolchain go1.24.1 directive
  • README.mdGo >= 1.23 install prerequisite
  • CONTRIBUTING.mdGo 1.23 or later development prerequisite

This PR brings them in line with go.mod's go 1.25.0 floor. The secondary go.mod drops its toolchain directive to match the main module. go.sum also gets the orphan-entry cleanup that was missed by the original Renovate bump.

Test plan

  • make ci passes locally (fmt, lint, unit tests, generated-files check)
  • cd test/go-integration && go build ./... succeeds against the bumped go.mod
  • PR Test workflow passes
  • Generator Integration Tests workflow passes

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the project's Go version requirement to 1.25 across the documentation, module files, and integration test environments. Additionally, it includes a significant cleanup of the go.sum file by removing redundant or older dependency versions. I have no feedback to provide as there were no review comments to evaluate.

PR #241 bumped the Dagger integration runners to Go 1.25 via a
centralized integration.GoBaseImage constant, but left the secondary
test/go-integration/go.mod and the contributor docs still pinned to
the previous minimum. Update those for consistency with go.mod's
go 1.25.0 floor.

Signed-off-by: Michael Beemer <beeme1mr@users.noreply.github.com>
@beeme1mr beeme1mr force-pushed the chore/bump-go-1.25 branch from 53948e7 to ec1d976 Compare April 28, 2026 01:07
@beeme1mr beeme1mr changed the title chore: align repo with Go 1.25 toolchain chore: align remaining Go 1.25 references in docs and test go.mod Apr 28, 2026
@beeme1mr beeme1mr merged commit e7e367d into main Apr 28, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants