Skip to content

enhancement: better model_save #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
getorca wants to merge 1 commit into
base: main
Choose a base branch
from
Open

enhancement: better model_save #13

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion train_mamba.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ def run(args):
per_device_train_batch_size=args.batch_size,
gradient_accumulation_steps=args.gradient_accumulation_steps,
optim=args.optim,
output_dir="mamba-chat",
output_dir=args.output_dir,
logging_steps=50,
save_steps=500,
),
Expand All @@ -44,6 +44,7 @@ def run(args):

trainer.train()

trainer.save_model(output_dir=f"{args.output_dir}/complete")

if __name__ == "__main__":
parser = argparse.ArgumentParser()
Expand All @@ -55,6 +56,7 @@ def run(args):
parser.add_argument("--optim", type=str, default="adamw_torch")
parser.add_argument("--data_path", type=str, default="./data/ultrachat_small.jsonl")
parser.add_argument("--num_epochs", type=int, default=1)
parser.add_argument("--output_dir", type=str, default="mamba-chat")
args = parser.parse_args()

run(args)
2 changes: 1 addition & 1 deletion trainer/mamba_trainer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ def compute_loss(self, model, inputs, return_outputs=False):

return lm_loss

def save_model(self, output_dir, _internal_call):
def save_model(self, output_dir, _internal_call: bool = False):
if not os.path.exists(output_dir):
os.makedirs(output_dir)

Expand Down