Skip to content

enhancement: better model_save#13

Open
getorca wants to merge 1 commit into
midrender:mainfrom
getorca:main
Open

enhancement: better model_save#13
getorca wants to merge 1 commit into
midrender:mainfrom
getorca:main

Conversation

@getorca
Copy link
Copy Markdown

@getorca getorca commented Dec 19, 2023

This pull request has 3 small changes to make saving the model easier:

  1. sets a default value for _internal_call in save_model like in hf trainer https://github.com/huggingface/transformers/blob/c48787f347bd604f656c2cfff730e029c8f8c1fe/src/transformers/trainer.py#L2797C12-L2797C12
  2. add arg parser for output_dir
  3. calls save_model when training is complete

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant