refactor: remove stale ManagedModel message management and AgentGraphResult type#170
Merged
jsonbailey merged 2 commits intomainfrom May 6, 2026
Merged
Conversation
…Result type Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…g blank line Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
keelerm84
approved these changes
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
get_messages()andappend_messages()fromManagedModel— conversation history is now managed entirely by the runner, not the managed layerAgentGraphResulttype, which was superseded byAgentGraphRunnerResult(output/LDAIMetrics→content/GraphMetrics) and has no remaining implementations or callers__all__references toAgentGraphResultacrossproviders/types.py,providers/__init__.py,ldai/__init__.py, and testsTest plan
pytest)AgentGraphResultis no longer importable fromldaiManagedModelno longer exposesget_messagesorappend_messages🤖 Generated with Claude Code
Note
Medium Risk
Removes previously exported/public APIs (
ManagedModel.get_messages/append_messagesandAgentGraphResult), which can be breaking for downstream consumers. Runtime risk is otherwise low since behavior is largely delegated to existing runner implementations.Overview
ManagedModelno longer maintains its own conversation history: message buffering,get_messages(), andappend_messages()are removed, and judge evaluation input is now just the currentpromptpassed to the runner.The stale
AgentGraphResultdataclass is deleted and all exports/imports/tests are updated to rely solely onAgentGraphRunnerResult(and correspondingGraphMetrics) vialdaiandldai.providers.Reviewed by Cursor Bugbot for commit 8beac8f. Bugbot is set up for automated code reviews on this repo. Configure here.