Skip to content

refactor: remove stale ManagedModel message management and AgentGraphResult type#170

Merged
jsonbailey merged 2 commits intomainfrom
jb/aic-2388/cleanup-managed-layer
May 6, 2026
Merged

refactor: remove stale ManagedModel message management and AgentGraphResult type#170
jsonbailey merged 2 commits intomainfrom
jb/aic-2388/cleanup-managed-layer

Conversation

@jsonbailey
Copy link
Copy Markdown
Contributor

@jsonbailey jsonbailey commented May 6, 2026

Summary

  • Removes get_messages() and append_messages() from ManagedModel — conversation history is now managed entirely by the runner, not the managed layer
  • Removes the orphaned AgentGraphResult type, which was superseded by AgentGraphRunnerResult (output/LDAIMetricscontent/GraphMetrics) and has no remaining implementations or callers
  • Cleans up all import and __all__ references to AgentGraphResult across providers/types.py, providers/__init__.py, ldai/__init__.py, and tests

Test plan

  • Existing unit tests pass (pytest)
  • Confirm AgentGraphResult is no longer importable from ldai
  • Confirm ManagedModel no longer exposes get_messages or append_messages

🤖 Generated with Claude Code


Note

Medium Risk
Removes previously exported/public APIs (ManagedModel.get_messages/append_messages and AgentGraphResult), which can be breaking for downstream consumers. Runtime risk is otherwise low since behavior is largely delegated to existing runner implementations.

Overview
ManagedModel no longer maintains its own conversation history: message buffering, get_messages(), and append_messages() are removed, and judge evaluation input is now just the current prompt passed to the runner.

The stale AgentGraphResult dataclass is deleted and all exports/imports/tests are updated to rely solely on AgentGraphRunnerResult (and corresponding GraphMetrics) via ldai and ldai.providers.

Reviewed by Cursor Bugbot for commit 8beac8f. Bugbot is set up for automated code reviews on this repo. Configure here.

jsonbailey and others added 2 commits May 5, 2026 20:03
…Result type

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…g blank line

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@jsonbailey jsonbailey marked this pull request as ready for review May 6, 2026 14:05
@jsonbailey jsonbailey requested a review from a team as a code owner May 6, 2026 14:05
@jsonbailey jsonbailey merged commit 7d6ad23 into main May 6, 2026
46 checks passed
@jsonbailey jsonbailey deleted the jb/aic-2388/cleanup-managed-layer branch May 6, 2026 14:35
@github-actions github-actions Bot mentioned this pull request May 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants