Skip to content
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions release-notes.txt
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
Release notes:

Unreleased
- test: rename `SideEffect` module to `SideEffects` in TaskSeq.Concat.Tests.fs, TaskSeq.Delay.Tests.fs, and TaskSeq.Item.Tests.fs for consistency with the rest of the test suite (50+ files already use the plural form)
- test: add SideEffects module and ImmTaskSeq variant tests to TaskSeq.ChunkBy.Tests.fs, improving coverage for chunkBy and chunkByAsync
- fixes: `Async.bind` signature corrected from `(Async<'T> -> Async<'U>)` to `('T -> Async<'U>)` to match standard monadic bind semantics (same as `Task.bind`); the previous signature made the function effectively equivalent to direct application
- refactor: simplify splitAt 'rest' taskSeq to use while!, removing redundant go2 mutable and manual MoveNextAsync pre-advance
Expand Down
2 changes: 1 addition & 1 deletion src/FSharp.Control.TaskSeq.Test/TaskSeq.Concat.Tests.fs
Original file line number Diff line number Diff line change
Expand Up @@ -181,7 +181,7 @@ module Immutable =
|> consumeTaskSeq
|> should throwAsyncExact typeof<NullReferenceException>

module SideEffect =
module SideEffects =
[<Fact>]
let ``TaskSeq-concat executes side effects of nested (taskseq)`` () =
let mutable i = 0
Expand Down
2 changes: 1 addition & 1 deletion src/FSharp.Control.TaskSeq.Test/TaskSeq.Delay.Tests.fs
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ module Immutable =
|> TaskSeq.delay
|> validateSequence

module SideEffect =
module SideEffects =
[<Fact>]
let ``TaskSeq-delay executes side effects`` () = task {
let mutable i = 0
Expand Down
2 changes: 1 addition & 1 deletion src/FSharp.Control.TaskSeq.Test/TaskSeq.Item.Tests.fs
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ module Immutable =
tail |> should equal (Some 10)
}

module SideEffect =
module SideEffects =
[<Theory; ClassData(typeof<TestSideEffectTaskSeq>)>]
let ``TaskSeq-item prove it searches the whole sequence`` variant = task {
let ts = Gen.getSeqWithSideEffect variant
Expand Down
Loading