Skip to content

[Repo Assist] test: rename SideEffect → SideEffects in Concat, Delay, and Item tests#408

Draft
github-actions[bot] wants to merge 2 commits intomainfrom
repo-assist/improve-sideeffects-naming-20260425-edfad27e8fbe8b06
Draft

[Repo Assist] test: rename SideEffect → SideEffects in Concat, Delay, and Item tests#408
github-actions[bot] wants to merge 2 commits intomainfrom
repo-assist/improve-sideeffects-naming-20260425-edfad27e8fbe8b06

Conversation

@github-actions
Copy link
Copy Markdown
Contributor

🤖 This is an automated pull request from Repo Assist, an AI assistant.

Summary

Three test files used module SideEffect = (singular) while the rest of the test suite — over 50 files — consistently uses module SideEffects = (plural). This PR fixes the naming inconsistency.

Files changed:

  • TaskSeq.Concat.Tests.fs: module SideEffectmodule SideEffects
  • TaskSeq.Delay.Tests.fs: module SideEffectmodule SideEffects
  • TaskSeq.Item.Tests.fs: module SideEffectmodule SideEffects

No tests were added or removed; this is a pure rename for consistency.

Test Status

  • ✅ Build: dotnet build src/FSharp.Control.TaskSeq.sln -c Release — succeeded (0 warnings, 0 errors)
  • ✅ Formatting: dotnet fantomas --check — clean
  • ✅ Tests: 1132 SideEffect-related tests passed (filtered run)

Generated by 🌈 Repo Assist, see workflow run. Learn more.

To install this agentic workflow, run

gh aw add githubnext/agentics/workflows/repo-assist.md@96b9d4c39aa22359c0b38265927eadb31dcf4e2a

50+ test files already use the plural 'SideEffects' module name.
Concat.Tests.fs, Delay.Tests.fs, and Item.Tests.fs were the only
outliers still using the singular form 'SideEffect'.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants