Skip to content

Increase valid starting times for github report #1849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AustinBenoit merged 2 commits into from
Apr 28, 2026
+3 −4
Merged

Increase valid starting times for github report #1849

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bd4a20a
Increase valid starting times for github report
AustinBenoit Apr 28, 2026
a28aa34
Make the github action only care about the hour
AustinBenoit Apr 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions scripts/gha/report_build_status.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,6 @@

general_test_hour = 9
firestore_test_hour = 10
test_time_minute_range = 20

def rename_key(old_dict,old_name,new_name):
"""Rename a key in a dictionary, preserving the order."""
Expand Down Expand Up @@ -388,9 +387,9 @@ def main(argv):
if run['day'] < start_date or run['day'] > end_date: continue
run['duration'] = dateutil.parser.parse(run['updated_at'], ignoretz=True) - run['date']
compare_test_hour = firestore_test_hour if FLAGS.firestore else general_test_hour
# The general test should start at 9:00, and firestore at 10:00, but we give it a range
# because the tests can take a few minutes before starting.
if run['date'].hour == compare_test_hour and run['date'].minute <= test_time_minute_range:
# The scheduled time is at the top of the hour (e.g. 09:00 or 10:00).
# We allow for some delay in GitHub Actions starting the job, as long as it starts in the same hour.
if run['date'].hour == compare_test_hour:
source_tests[day] = run
all_days.add(day)

Expand Down
Loading