Increase valid starting times for github report#1849
Merged
AustinBenoit merged 2 commits intomainfrom Apr 28, 2026
Merged
Conversation
The github actions that run as a part of our nightly reports often start later than expected. We previously allowed for a 20 minute delay but now we can allow for a 59 minute delay. 59 minutes is the longest possible delay that should still not cause confusion when reporting the results.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the test_time_minute_range from 20 to 59 in the build status reporting script. Feedback suggests that setting this value to 59 makes the subsequent minute check redundant and highlights a potential logic flaw where tests delayed past the hour boundary might be missed, recommending a more robust time-delta comparison.
a-maurice
approved these changes
Apr 28, 2026
github-actions
Bot
added
the
tests: in-progress
⏳ Integration test in progress...Requested by @AustinBenoit on commit 3fe6b6e |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The github actions that run as a part of our nightly reports often start later than expected. We previously allowed for a 20 minute delay. Now we should just care about which hour in which the job was started. Recently we have had delays up to 45 minutes.
Testing
...
Type of Change
Place an
xthe applicable box:Notes
Release Notessection ofrelease_build_files/readme.md.