Skip to content

fix: build-scripts/get_labels_expr.py needs to output "true" in case no labels are found (3.24) #2218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
craigcomstock wants to merge 1 commit into
base: 3.24.x
Choose a base branch
from
+4 −1
Draft

fix: build-scripts/get_labels_expr.py needs to output "true" in case no labels are found (3.24) #2218

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion build-scripts/get_labels_expr.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,10 @@ def main(labels_f_path, exotics_f_path, run_on_exotics, only_exotics):
else:
labels_to_run = all_labels

if len(labels_to_run) != 0:
if len(labels_to_run) == 0:
# if no labels are found we print true to be a no-op in an expression that likely includes other elements like no exotics or specific labels
Copy link
Copy Markdown
Member

@nickanderson nickanderson Apr 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

might be nice to have a concrete example

print("true")
else:
print("(", end="")
labels_eqs = ('label == "%s"' % label for label in sorted(labels_to_run))
print(" || \\\n ".join(labels_eqs) + ")")
Expand Down