fix: build-scripts/get_labels_expr.py needs to output "true" in case no labels are found (3.24)#2218
Draft
craigcomstock wants to merge 1 commit intocfengine:3.24.xfrom
Draft
fix: build-scripts/get_labels_expr.py needs to output "true" in case no labels are found (3.24)#2218craigcomstock wants to merge 1 commit intocfengine:3.24.xfrom
craigcomstock wants to merge 1 commit intocfengine:3.24.xfrom
Conversation
…no labels are found
e.g. when a build will not include exotics a partial expression is pre-pended to the output of this script
EXOTIX_CONFIGURATIONS_FILTER: (!label.contains("mingw") && !label.contains("_HUB_") && !label.contains("hpux") && !label.contains("aix") && !label.contains("solaris")) && \
so a true at the end of that expression will be a no-op and appropriate.
Ticket: ENT-14025
Changelog: none
(cherry picked from commit 810e1f9)
nickanderson
approved these changes
Apr 29, 2026
|
|
||
| if len(labels_to_run) != 0: | ||
| if len(labels_to_run) == 0: | ||
| # if no labels are found we print true to be a no-op in an expression that likely includes other elements like no exotics or specific labels |
Member
There was a problem hiding this comment.
might be nice to have a concrete example
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
e.g. when a build will not include exotics a partial expression is pre-pended to the output of this script
EXOTIX_CONFIGURATIONS_FILTER: (!label.contains("mingw") && !label.contains("HUB") && !label.contains("hpux") && !label.contains("aix") && !label.contains("solaris")) && \
so a true at the end of that expression will be a no-op and appropriate.
Ticket: ENT-14025
Changelog: none
(cherry picked from commit 810e1f9)