SYNCOPE-1758 Avoid CAS servlet reinitialization in WA#1390
Open
frhack wants to merge 1 commit into
Open
Conversation
Define the WA-specific CAS configuration event listener in WAContext so it is loaded by Spring runtime, preserving refresh and rebind behavior while avoiding DispatcherServlet.init() without ServletConfig. Tracks upstream root cause in apereo/cas#8974.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the
4_1_Xversion of #1389, following the review feedback there.The PR defines the WA-specific
casConfigurationEventListenerbean directly inWAContext, so it is picked up by Spring runtime, and keeps the same eager/non-lazy refresh listener contract as CAS.The listener preserves CAS refresh/rebind behavior, but avoids manually invoking
DispatcherServlet.init()during refresh. In Syncope WA that servlet has noServletConfigat that point, which can trigger theIllegalStateExceptionreported in SYNCOPE-1758.Upstream CAS root cause fix: apereo/cas#8974
Tested with: