SYNCOPE-1758 Avoid CAS servlet reinitialization in WA#1389
Closed
frhack wants to merge 1 commit into
Closed
Conversation
Override CAS' configuration refresh listener in the WA starter so refresh still eagerly resolves beans but does not manually call DispatcherServlet.init() without ServletConfig. This keeps Syncope WA protected while upstream CAS tracks the root cause in apereo/cas#8974.
Member
|
Moreover, if this is your very first contribution to an ASF project, please ensure to submit your ICLA. |
ilgrosso
reviewed
May 17, 2026
| @Configuration(proxyBeanMethods = false) | ||
| public class WACasConfiguration { | ||
|
|
||
| @ConditionalOnMissingBean(name = "casConfigurationEventListener") |
Member
There was a problem hiding this comment.
Move this bean definition into WAContext and remove this class.
FTR this class is going to be ignored by Spring runtime.
Author
|
Reworked this on Closing this |
Author
|
Superseded by #1390. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This overrides CAS' configuration refresh listener in the WA starter so refresh still eagerly resolves beans, but no longer manually calls
DispatcherServlet.init()without aServletConfig.The root cause is tracked upstream in CAS:
apereo/cas#8974
Syncope 3.0.x currently depends on CAS 6.6.x, and that CAS release line is EOL, so this keeps Syncope WA protected without waiting for a usable upstream CAS release on the 6.6 line.
Changes:
casConfigurationEventListenerbean.DispatcherServletinitialization.dispatcherServletis resolved but not reinitialized.Tests:
/tmp/maven/apache-maven-3.9.11/bin/mvn -pl wa/starter -am -Dtest=WACasConfigurationEventListenerTest -Dsurefire.failIfNoSpecifiedTests=false test