Skip to content

fix(ci): restore auth for docs gh-pages deploy#625

Merged
wgtmac merged 2 commits intoapache:mainfrom
wgtmac:fix_site_ci
Apr 24, 2026
Merged

fix(ci): restore auth for docs gh-pages deploy#625
wgtmac merged 2 commits intoapache:mainfrom
wgtmac:fix_site_ci

Conversation

@wgtmac
Copy link
Copy Markdown
Member

@wgtmac wgtmac commented Apr 24, 2026

No description provided.

@wgtmac
Copy link
Copy Markdown
Member Author

wgtmac commented Apr 24, 2026

@kevinjqliu I'm not sure if this is the right approach to fix https://github.com/apache/iceberg-cpp/actions/runs/24883794037/job/72858619932. I can only verify it by merging this PR.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Restores authenticated git access for the documentation deployment job so the workflow can push the generated site to the gh-pages branch from main.

Changes:

  • Exposes GITHUB_TOKEN to the deploy step environment.
  • Updates the origin remote URL to use token-based HTTPS authentication before pushing to gh-pages.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Copy Markdown
Contributor

@kevinjqliu kevinjqliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great catch! this should work, similar to https://github.com/apache/iceberg/blob/main/.github/workflows/site-ci.yml

one nit: we can make the permissions more granular by moving contents: write to the job level, like so https://github.com/apache/iceberg/blob/f475ccb5c579b8a1d4842507b12e854161dea7af/.github/workflows/site-ci.yml#L30-L37

Comment thread .github/workflows/docs.yml Outdated
Co-authored-by: Kevin Liu <kevinjqliu@users.noreply.github.com>
@wgtmac
Copy link
Copy Markdown
Member Author

wgtmac commented Apr 24, 2026

Thanks @kevinjqliu! I will explore that later. Let me fix this the breaking site first.

@wgtmac wgtmac merged commit ce794ef into apache:main Apr 24, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants