feat: v2 - runs and submissions - add latest run#2199
Conversation
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
🎩 PreviewA preview build has been created at: |
363ba9f to
8d997d9
Compare
43e295f to
effa810
Compare
8d997d9 to
8a7e548
Compare
effa810 to
490871b
Compare
8a7e548 to
205308a
Compare
490871b to
a2f61c0
Compare
205308a to
4c0fa3e
Compare
a2f61c0 to
564779d
Compare
564779d to
abdd78c
Compare
|
I'm also not a huge fan of the show all runs being a pop-up. What's stopping us from putting all the runs in most recent runs in a list that is scrollable or expandable? |
| <Separator /> | ||
| <BlockStack className="p-2"> | ||
| <InlineStack align="space-between" className="w-full"> | ||
| <Heading level={3}>The most recent run:</Heading> | ||
| {showMoreButton} | ||
| </InlineStack> | ||
| <div className="flex-1 min-h-0 overflow-y-auto w-full"> | ||
| <PipelineRunsList | ||
| pipelineName={pipelineName} | ||
| showTitle={false} | ||
| defaultShowingRuns={1} | ||
| showMoreButton={false} | ||
| overviewConfig={{ | ||
| showName: false, | ||
| showDescription: true, | ||
| showTaskStatusBar: false, | ||
| }} | ||
| /> | ||
| </div> | ||
| </BlockStack> |
There was a problem hiding this comment.
food for thought. DONT CHANGE HERE!
Maybe we add a prop to the block stack component that allows you to define a separator above or below or both. That way we don't have to manually add separators in throughout the code.
abdd78c to
5891b89
Compare
8d911fa to
c4834fd
Compare
5891b89 to
62299cd
Compare
c4834fd to
5939dc6
Compare

Description
Contributes to https://github.com/Shopify/oasis-frontend/issues/613
Adds a "most recent run" section to the
RunsAndSubmissionContentpanel in the Editor. This displays the latest pipeline run directly within the runs and submission sidebar, along with a "Show all runs" button that opens the full recent executions list when a pipeline name is available.UX: the most recent run appears immediately , so it is easier to reach compared to toast message. "Show all runs" - questionable, since there is a dedicated window for this, so looking for opinions
Related Issue and Pull requests
Type of Change
Checklist
Screenshots (if applicable)
Test Instructions
Additional Comments
The
PipelineRunsListis configured to show only 1 run by default, with the name and task status bar hidden, but the description visible.