feat: v2 - ensure window order while seeding default layout#2198
Open
maxy-shpfy wants to merge 1 commit into05-03-feat_v2_-_add_runs_and_submissions_windowfrom
Conversation
This was referenced May 4, 2026
🎩 PreviewA preview build has been created at: |
3 tasks
Collaborator
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced May 4, 2026
3c7b3e1 to
f300e35
Compare
8d997d9 to
8a7e548
Compare
f300e35 to
7fbeb40
Compare
205308a to
4c0fa3e
Compare
8 tasks
Mbeaulne
approved these changes
May 5, 2026
4c0fa3e to
2f273c0
Compare
7fbeb40 to
0ba40ca
Compare
2f273c0 to
73f69bd
Compare
0ba40ca to
50ed8a5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
On a user's first visit to the editor (when no window layout exists in
localStorage), the dock panel stacks are now automatically seeded to match theDEFAULT_VIEW_PRESETordering. Previously, windows would appear in registration order rather than the intended preset order.This was achieved by:
dockPositions: Record<string, "left" | "right">shape onViewPresetwith a structureddockAreas: PresetDockAreasobject ({ left: string[], right: string[] }), where array order defines the desired stack order.dockSideByWindowIdutility that derives aMap<id, side>from aPresetDockAreasobject, used byapplyViewPresetto correct dock sides without reshuffling stack order.seedInitialDockLayoutFromPresetonWindowStoreImpl, which both corrects dock sides and rewriteswindowOrderfor each dock column to match the preset's declared order. This is intentionally called only when no persisted layout exists.useSeedInitialDockLayoutFromPresethook that gates the call onhasPersistedLayout()and wires it into the editor on mount.Related Issue and Pull requests
Type of Change
Checklist
Screenshots (if applicable)
Screen Recording 2026-05-04 at 1.43.48 PM.mov (uploaded via Graphite)
Test Instructions
localStorage(or open a private/incognito window) so no persisted dock layout exists.DEFAULT_DOCK_AREAS(left:runs-and-submission,component-library,pipeline-tree,history,debug-panel,recent-runs; right:pipeline-details,context-panel).Additional Comments
The
applyViewPresetmethod intentionally does not reorder stacks — it only corrects which side a window belongs to. Stack order seeding is exclusively the responsibility ofseedInitialDockLayoutFromPreset, which runs once on first visit.