Skip to content

Share HTTP source credential editor#816

Open
RhysSullivan wants to merge 1 commit into
standardize-http-credential-uifrom
standardize-http-source-state
Open

Share HTTP source credential editor#816
RhysSullivan wants to merge 1 commit into
standardize-http-credential-uifrom
standardize-http-source-state

Conversation

@RhysSullivan
Copy link
Copy Markdown
Owner

@RhysSullivan RhysSullivan commented May 14, 2026

Summary

  • Replaces the narrow edit-form credential hook with a dependency-injected HttpCredentialEditor controller that exposes shared state, dirty/valid flags, request serialization, scoped serialization, and configured binding serialization.
  • Adds compound editor primitives for shared headers, query params, and auth method option UI, so GraphQL, MCP, and OpenAPI compose the same frontend pieces instead of each owning bespoke credential cards.
  • Moves GraphQL and MCP add/edit forms plus OpenAPI spec-fetch credentials, header auth credentials, runtime query params, and auth preset picker onto the shared controller/compound surface.
  • Removes the extra editor context/frame wrapper so HttpCredentialEditor.Provider directly hosts the existing credential compound components.
  • Keeps plugin-specific behavior at the edge: OpenAPI still owns spec-derived header/OAuth preset behavior, while the shared layer owns HTTP credential editing and serialization.

Diff shape

  • Plugin form files: +243 / -431 (-188 LOC)
  • Shared React plugin files: +408 / -3 (+405 LOC)
  • Total PR: +651 / -434

Tests

  • bun run format:check
  • bun run lint
  • bun run typecheck
  • git diff --check
  • cd packages/react && bun run typecheck
  • cd packages/plugins/graphql && bun run typecheck
  • cd packages/plugins/mcp && bun run typecheck
  • cd packages/plugins/openapi && bun run typecheck
  • cd packages/react && bun run test -- src/plugins/http-credentials.test.ts src/plugins/credential-bindings.test.ts
  • cd packages/plugins/graphql && bun run test -- src/react/defaults.test.ts
  • cd apps/local && bunx --bun vitest run src/server/migrate-graphql-bindings.test.ts --testTimeout=30000 --maxWorkers=1

Notes

  • bun run test was attempted. The workspace run passed all non-local packages but failed in @executor-js/local migration/db-upgrade tests because those tests exceed the default 5s Vitest timeout in this environment. A representative migration file passes with a longer timeout and one worker.

Stack

  1. Standardize source credential binding API #810
  2. Share HTTP credential handling for source plugins #813
  3. Refactor HTTP credential UI composition #815
  4. Share HTTP source credential editor #816 👈 current

@cloudflare-workers-and-pages
Copy link
Copy Markdown

cloudflare-workers-and-pages Bot commented May 14, 2026

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
executor-marketing 18443d9 Commit Preview URL

Branch Preview URL
May 14 2026, 09:14 AM

@cloudflare-workers-and-pages
Copy link
Copy Markdown

cloudflare-workers-and-pages Bot commented May 14, 2026

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Updated (UTC)
✅ Deployment successful!
View logs
executor-cloud 18443d9 May 14 2026, 09:14 AM

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented May 14, 2026

Open in StackBlitz

@executor-js/cli

npm i https://pkg.pr.new/@executor-js/cli@816

@executor-js/config

npm i https://pkg.pr.new/@executor-js/config@816

@executor-js/execution

npm i https://pkg.pr.new/@executor-js/execution@816

@executor-js/sdk

npm i https://pkg.pr.new/@executor-js/sdk@816

@executor-js/storage-core

npm i https://pkg.pr.new/@executor-js/storage-core@816

@executor-js/codemode-core

npm i https://pkg.pr.new/@executor-js/codemode-core@816

@executor-js/runtime-quickjs

npm i https://pkg.pr.new/@executor-js/runtime-quickjs@816

@executor-js/plugin-file-secrets

npm i https://pkg.pr.new/@executor-js/plugin-file-secrets@816

@executor-js/plugin-google-discovery

npm i https://pkg.pr.new/@executor-js/plugin-google-discovery@816

@executor-js/plugin-graphql

npm i https://pkg.pr.new/@executor-js/plugin-graphql@816

@executor-js/plugin-keychain

npm i https://pkg.pr.new/@executor-js/plugin-keychain@816

@executor-js/plugin-mcp

npm i https://pkg.pr.new/@executor-js/plugin-mcp@816

@executor-js/plugin-onepassword

npm i https://pkg.pr.new/@executor-js/plugin-onepassword@816

@executor-js/plugin-openapi

npm i https://pkg.pr.new/@executor-js/plugin-openapi@816

executor

npm i https://pkg.pr.new/executor@816

commit: 18443d9

@RhysSullivan RhysSullivan force-pushed the standardize-http-source-state branch from f63b33e to e01f2aa Compare May 14, 2026 08:33
@RhysSullivan RhysSullivan changed the title Share HTTP source credential state Share HTTP source credential editor May 14, 2026
@RhysSullivan RhysSullivan force-pushed the standardize-http-source-state branch from e01f2aa to 18443d9 Compare May 14, 2026 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant