Skip to content

Refactor HTTP credential UI composition#815

Open
RhysSullivan wants to merge 1 commit into
standardize-http-credentialsfrom
standardize-http-credential-ui
Open

Refactor HTTP credential UI composition#815
RhysSullivan wants to merge 1 commit into
standardize-http-credentialsfrom
standardize-http-credential-ui

Conversation

@RhysSullivan
Copy link
Copy Markdown
Owner

@RhysSullivan RhysSullivan commented May 14, 2026

Summary

  • Standardizes HTTP credential UI around HttpCredentials: headers and query parameters now share the same value-source select, scope picker, and serialization path across GraphQL, MCP, and OpenAPI.
  • Removes MCP's separate plaintext header editor; plaintext headers are now Plain value rows in the shared request credentials UI, while secret-backed values use Saved secret.
  • Adds a shared OAuth connection/status control used by MCP and OpenAPI for the saved-to scope row plus idle/busy/connected/blocked status rendering. Provider-specific OAuth setup stays outside the shared control.
  • Splits reusable secret creation into creatable-secret-picker and removes the old secret-header-auth / headers-list surfaces.

Tests

  • bun run format:check
  • bun run lint
  • bun run typecheck
  • git diff --check
  • cd packages/react && bun run typecheck
  • cd packages/react && bun run test -- src/plugins/http-credentials.test.ts src/plugins/credential-bindings.test.ts src/plugins/secret-helpers.test.ts
  • cd packages/plugins/mcp && bun run test -- src/sdk/plugin.test.ts src/sdk/per-user-auth-isolation.test.ts src/sdk/connection-pool.test.ts src/react/defaults.test.ts
  • cd packages/plugins/openapi && bun run test -- src/sdk/plugin.test.ts src/sdk/multi-scope-bearer.test.ts src/sdk/multi-scope-oauth.test.ts src/sdk/client-credentials-oauth.test.ts src/sdk/oauth-refresh.test.ts

Stack

  1. Standardize source credential binding API #810
  2. Share HTTP credential handling for source plugins #813
  3. Refactor HTTP credential UI composition #815 👈 current
  4. Share HTTP source credential editor #816

@cloudflare-workers-and-pages
Copy link
Copy Markdown

cloudflare-workers-and-pages Bot commented May 14, 2026

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
executor-marketing 6dec2e1 Commit Preview URL

Branch Preview URL
May 14 2026, 07:51 AM

@cloudflare-workers-and-pages
Copy link
Copy Markdown

cloudflare-workers-and-pages Bot commented May 14, 2026

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Updated (UTC)
✅ Deployment successful!
View logs
executor-cloud 6dec2e1 May 14 2026, 07:52 AM

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented May 14, 2026

Open in StackBlitz

@executor-js/cli

npm i https://pkg.pr.new/@executor-js/cli@815

@executor-js/config

npm i https://pkg.pr.new/@executor-js/config@815

@executor-js/execution

npm i https://pkg.pr.new/@executor-js/execution@815

@executor-js/sdk

npm i https://pkg.pr.new/@executor-js/sdk@815

@executor-js/storage-core

npm i https://pkg.pr.new/@executor-js/storage-core@815

@executor-js/codemode-core

npm i https://pkg.pr.new/@executor-js/codemode-core@815

@executor-js/runtime-quickjs

npm i https://pkg.pr.new/@executor-js/runtime-quickjs@815

@executor-js/plugin-file-secrets

npm i https://pkg.pr.new/@executor-js/plugin-file-secrets@815

@executor-js/plugin-google-discovery

npm i https://pkg.pr.new/@executor-js/plugin-google-discovery@815

@executor-js/plugin-graphql

npm i https://pkg.pr.new/@executor-js/plugin-graphql@815

@executor-js/plugin-keychain

npm i https://pkg.pr.new/@executor-js/plugin-keychain@815

@executor-js/plugin-mcp

npm i https://pkg.pr.new/@executor-js/plugin-mcp@815

@executor-js/plugin-onepassword

npm i https://pkg.pr.new/@executor-js/plugin-onepassword@815

@executor-js/plugin-openapi

npm i https://pkg.pr.new/@executor-js/plugin-openapi@815

executor

npm i https://pkg.pr.new/executor@815

commit: 6dec2e1

@RhysSullivan RhysSullivan force-pushed the standardize-http-credential-ui branch from d3141e8 to b5d2c74 Compare May 14, 2026 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant