Skip to content

feat: add Qrevo S5V dock type code (22) to RoborockDockTypeCode #829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
justprox wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: add Qrevo S5V dock type code (22) to RoborockDockTypeCode #829

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions roborock/data/v1/v1_code_mappings.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -664,6 +664,7 @@ class RoborockDockTypeCode(RoborockEnum):
saros_r10_dock = 16
qrevo_curv_dock = 17
saros_10_dock = 18
qrevo_s5v_dock = 22


class RoborockDockDustCollectionModeCode(RoborockEnum):
Expand Down
1 change: 1 addition & 0 deletions roborock/device_features.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -653,6 +653,7 @@ def get_supported_features(self) -> list[str]:
RoborockDockTypeCode.qrevo_s_dock,
RoborockDockTypeCode.saros_r10_dock,
RoborockDockTypeCode.qrevo_curv_dock,
RoborockDockTypeCode.qrevo_s5v_dock,
]


Expand Down
9 changes: 9 additions & 0 deletions tests/data/v1/test_v1_containers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -263,6 +263,15 @@ def test_no_value():
assert "missing" not in RoborockDockTypeCode.values()


def test_qrevo_s5v_dock_type():
"""Test that dock type code 22 (Qrevo S5V dock) is properly recognized."""
modified_status = STATUS.copy()
modified_status["dock_type"] = 22
s = S7MaxVStatus.from_dict(modified_status)
assert s.dock_type == RoborockDockTypeCode.qrevo_s5v_dock
assert s.dock_type.value == 22


def test_multi_maps_list_info(snapshot: SnapshotAssertion) -> None:
"""Test that MultiMapsListInfo can be deserialized correctly."""
data = {
Expand Down
1 change: 1 addition & 0 deletions tests/devices/traits/v1/test_dust_collection_mode.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ def dust_collection_mode_trait(
(RoborockDockTypeCode.s8_dock),
(RoborockDockTypeCode.p10_dock),
(RoborockDockTypeCode.qrevo_s_dock),
(RoborockDockTypeCode.qrevo_s5v_dock),
],
)
async def test_dust_collection_mode_available(
Expand Down
1 change: 1 addition & 0 deletions tests/devices/traits/v1/test_smart_wash_params.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ def smart_wash_params_trait(
(RoborockDockTypeCode.s8_dock),
(RoborockDockTypeCode.p10_dock),
(RoborockDockTypeCode.qrevo_s_dock),
(RoborockDockTypeCode.qrevo_s5v_dock),
],
)
async def test_smart_wash_available(
Expand Down
1 change: 1 addition & 0 deletions tests/devices/traits/v1/test_wash_towel_mode.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ def wash_towel_mode_trait(
(RoborockDockTypeCode.s8_dock),
(RoborockDockTypeCode.p10_dock),
(RoborockDockTypeCode.qrevo_s_dock),
(RoborockDockTypeCode.qrevo_s5v_dock),
],
)
async def test_wash_towel_mode_available(
Expand Down