feat: add Qrevo S5V dock type code (22) to RoborockDockTypeCode#829
Open
justprox wants to merge 1 commit intoPython-roborock:mainfrom
Open
feat: add Qrevo S5V dock type code (22) to RoborockDockTypeCode#829justprox wants to merge 1 commit intoPython-roborock:mainfrom
justprox wants to merge 1 commit intoPython-roborock:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
qrevo_s5v_dock(code 22) toRoborockDockTypeCodeenum inv1_code_mappings.pyWASH_N_FILL_DOCK_TYPESindevice_features.pysince the Qrevo S5V dock is a wash-and-fill dockContext
The Roborock Qrevo S5V vacuum dock reports dock type code 22, which was not previously defined in the library. This caused a warning log on every Home Assistant startup:
While the
_missing_method gracefully falls back tounknown, this clutters logs and means the dock type isn't properly identified. The Qrevo S5V is a 2025 model with a multi-function wash dock (same dock family as the Qrevo Curv, code 17).Changes
roborock/data/v1/v1_code_mappings.pyqrevo_s5v_dock = 22roborock/device_features.pyWASH_N_FILL_DOCK_TYPESlisttests/data/v1/test_v1_containers.pytests/devices/traits/v1/test_wash_towel_mode.pytests/devices/traits/v1/test_dust_collection_mode.pytests/devices/traits/v1/test_smart_wash_params.pyAll 56 affected tests pass.