Skip to content

feat: add Qrevo S5V dock type code (22) to RoborockDockTypeCode#829

Open
justprox wants to merge 1 commit intoPython-roborock:mainfrom
justprox:add-qrevo-s5v-dock-type
Open

feat: add Qrevo S5V dock type code (22) to RoborockDockTypeCode#829
justprox wants to merge 1 commit intoPython-roborock:mainfrom
justprox:add-qrevo-s5v-dock-type

Conversation

@justprox
Copy link
Copy Markdown

@justprox justprox commented May 9, 2026

Summary

  • Add qrevo_s5v_dock (code 22) to RoborockDockTypeCode enum in v1_code_mappings.py
  • Add the new dock type to WASH_N_FILL_DOCK_TYPES in device_features.py since the Qrevo S5V dock is a wash-and-fill dock
  • Add test coverage for the new dock type code

Context

The Roborock Qrevo S5V vacuum dock reports dock type code 22, which was not previously defined in the library. This caused a warning log on every Home Assistant startup:

Missing RoborockDockTypeCode code: 22 - defaulting to 'unknown'

While the _missing_ method gracefully falls back to unknown, this clutters logs and means the dock type isn't properly identified. The Qrevo S5V is a 2025 model with a multi-function wash dock (same dock family as the Qrevo Curv, code 17).

Changes

File Change
roborock/data/v1/v1_code_mappings.py Added qrevo_s5v_dock = 22
roborock/device_features.py Added to WASH_N_FILL_DOCK_TYPES list
tests/data/v1/test_v1_containers.py Added test for code 22 recognition
tests/devices/traits/v1/test_wash_towel_mode.py Added qrevo_s5v_dock to parametrized tests
tests/devices/traits/v1/test_dust_collection_mode.py Added qrevo_s5v_dock to parametrized tests
tests/devices/traits/v1/test_smart_wash_params.py Added qrevo_s5v_dock to parametrized tests

All 56 affected tests pass.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant