Skip to content

Support module unload in modules file; unload xalt on Phoenix GPU #1387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sbryngelson merged 2 commits into from
Apr 30, 2026
+10 −2
Merged

Support module unload in modules file; unload xalt on Phoenix GPU #1387

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6bb92e6
Support module unload in modules file; unload xalt on Phoenix GPU
sbryngelson Apr 29, 2026
3faf483
run tests
sbryngelson Apr 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/simulation/m_rhs.fpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ module m_rhs
$:GPU_DECLARE(create='[tau_Re_vf]')

!> @name The cell-boundary values of the fluxes (src - source, gsrc - geometrical source). These are computed by applying the
!! chosen Riemann problem solver .on the left and right cell-boundary values of the primitive variables
!! chosen Riemann problem solver on the left and right cell-boundary values of the primitive variables
!> @{
type(vector_field), allocatable, dimension(:) :: flux_n
type(vector_field), allocatable, dimension(:) :: flux_src_n
Expand Down
7 changes: 7 additions & 0 deletions toolchain/bootstrap/modules.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,6 +119,13 @@ if [ $(echo "$VARIABLES" | grep = | wc -c) -gt 0 ]; then
export $(eval "echo $VARIABLES") > /dev/null
fi

UNLOAD_MODULES="$(__extract "$u_c-all-unload") $(__extract "$u_c-$cg-unload")"
UNLOAD_MODULES=$(echo "$UNLOAD_MODULES" | xargs)
if [ -n "$UNLOAD_MODULES" ]; then
log " $ module unload $UNLOAD_MODULES"
module unload $UNLOAD_MODULES
fi

# Don't check for Cray paths on Carpenter, otherwise do check if they exist
if [ ! -z ${CRAY_LD_LIBRARY_PATH+x} ] && [ "$u_c" '!=' 'c' ] && [ "$u_c" '!=' 'famd' ] ; then
ok "Found $M\$CRAY_LD_LIBRARY_PATH$CR. Prepending to $M\$LD_LIBRARY_PATH$CR."
Expand Down
3 changes: 2 additions & 1 deletion toolchain/modules
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@ p-all python/3.12.5
p-cpu gcc/12.3.0 openmpi/4.1.5
p-gpu python/3.12.5 nvhpc/24.5 hpcx/2.19-cuda cuda/12.1.1
p-gpu MFC_CUDA_CC=70,75,80,89,90 NVHPC_CUDA_HOME=$CUDA_HOME CC=nvc CXX=nvc++ FC=nvfortran
p-gpu-unload xalt

f OLCF Frontier
f-all cpe/25.03 rocm/6.3.1
Expand Down Expand Up @@ -113,4 +114,4 @@ h-gpu NVCOMPILER_COMM_LIBS_HOME=/apps/compilers/nvhpc/25.9/Linux_x86_64/25.9/com

t WPI Turing
t-all slurm
t-cpu gcc/12.1.0/i6yk33f openmpi/4.1.3/ebae7zc python/3.13.5/6anz4qy
t-cpu gcc/12.1.0/i6yk33f openmpi/4.1.3/ebae7zc python/3.13.5/6anz4qy
Loading