Skip to content

Support module unload in modules file; unload xalt on Phoenix GPU#1387

Merged
sbryngelson merged 2 commits intoMFlowCode:masterfrom
sbryngelson:unload-modules
Apr 30, 2026
Merged

Support module unload in modules file; unload xalt on Phoenix GPU#1387
sbryngelson merged 2 commits intoMFlowCode:masterfrom
sbryngelson:unload-modules

Conversation

@sbryngelson
Copy link
Copy Markdown
Member

@sbryngelson sbryngelson commented Apr 29, 2026

Summary

  • Adds <slug>-[all|cpu|gpu]-unload line support to toolchain/modules for specifying modules to unload after loading
  • Unloads xalt on Phoenix GPU (p-gpu-unload xalt)

Test plan

  • Source ./mfc.sh load -c p -m g on Phoenix and verify xalt is unloaded at the end

@sbryngelson sbryngelson marked this pull request as ready for review April 29, 2026 19:54
@qodo-code-review
Copy link
Copy Markdown
Contributor

ⓘ You've reached your Qodo monthly free-tier limit. Reviews pause until next month — upgrade your plan to continue now, or link your paid account if you already have one.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 29, 2026

Warning

Rate limit exceeded

@sbryngelson has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 30 minutes and 14 seconds before requesting another review.

To keep reviews running without waiting, you can enable usage-based add-on for your organization. This allows additional reviews beyond the hourly cap. Account admins can enable it under billing.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 7e3e373a-46a3-4954-9331-65277d4e4399

📥 Commits

Reviewing files that changed from the base of the PR and between 00aa603 and 3faf483.

📒 Files selected for processing (3)
  • src/simulation/m_rhs.fpp
  • toolchain/bootstrap/modules.sh
  • toolchain/modules

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
Review rate limit: 0/1 reviews remaining, refill in 30 minutes and 14 seconds.

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 29, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 64.76%. Comparing base (00aa603) to head (3faf483).
⚠️ Report is 4 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1387   +/-   ##
=======================================
  Coverage   64.76%   64.76%           
=======================================
  Files          71       71           
  Lines       18713    18713           
  Branches     1549     1549           
=======================================
  Hits        12119    12119           
  Misses       5638     5638           
  Partials      956      956           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sbryngelson sbryngelson merged commit bb10bcd into MFlowCode:master Apr 30, 2026
135 of 143 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant