Skip to content

feat(Roles): add option for icon data in role datas#7528

Open
hjpalpha wants to merge 3 commits into
mainfrom
support-icon-in-role-datas
Open

feat(Roles): add option for icon data in role datas#7528
hjpalpha wants to merge 3 commits into
mainfrom
support-icon-in-role-datas

Conversation

@hjpalpha
Copy link
Copy Markdown
Collaborator

Summary

as title states

this allows to eventually migrate data from Module:PositionIcon/data to role data modules

How did you test this change?

dev as port of original #7523

@mbergen
Copy link
Copy Markdown
Collaborator

mbergen commented May 18, 2026

Should we already prepare a clean way to add non-FA icons instead of just raw wikicode strings?

Comment thread lua/wikis/commons/Role/Util.lua Outdated
@hjpalpha
Copy link
Copy Markdown
Collaborator Author

Should we already prepare a clean way to add non-FA icons instead of just raw wikicode strings?

done

although we will have to see how to handle dota2 with this when we port the data:
image

@hjpalpha hjpalpha requested review from ElectricalBoy and mbergen May 18, 2026 14:55
Copy link
Copy Markdown
Collaborator

@Eetwalt Eetwalt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#7523 (comment)

After this product decisions, do we need to have icon mapping option for Roles? Was this only for 'captain' and 'igl' or would this be beneficial for defining ingamerole icons as well?

@hjpalpha
Copy link
Copy Markdown
Collaborator Author

hjpalpha commented May 19, 2026

#7523 (comment)

After this product decisions, do we need to have icon mapping option for Roles? Was this only for 'captain' and 'igl' or would this be beneficial for defining ingamerole icons as well?

longterm we would want to get rid of Module:PositionIcon/data and move the data from it into roles
for that we would need something like this here anyways

but if we go without icons for igl/captain in TP then we can postpone this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants