feat(TeamParticipants): improve ingame role display for roles without icon

[hjpalpha]

Summary

resolves #7491
also adds a missing return anno

before:

with this:

How did you test this change?

dev

[hjpalpha]

failed unit tests are unrelated to the PR ...

[Rathoz]

IIRC, IGL and Captain should not be considered as IngameRoles, but should be Staff Roles.

[hjpalpha]

IIRC, IGL and Captain should not be considered as IngameRoles, but should be Staff Roles.

it would make them staff in TP ...
which is just wrong, especially storage wise

additionally at least for sc2 the ingame captain does not necessarily have to be a role in the team/org as such
there are events on sc2 where the "teams" are "formed" in a selection process and then the first player that gets selected into a team gets to be the "captain" of said team

[hjpalpha]

fwiw this also happens with real ingame roles if they don't have icon set up,
e.g. with awper on cs:

it just looks shit on the left in general if the role has no icon ...

[Eetwalt]

While I agree that Captain & IGL aren't really staff roles, I also don't like showing them as additional badge on the right as we're tight on space there already. Let's say we have a longer name and we also have Stand-in/trophies/ loan team on the example above, we would run out of space.

Would it make sense to have a global icon for Captain and IGL and keep them on the left? In general, I think we should standardize it so if we have icon, show it, if not, don't show anything. @PiddyNydra thoughts?

[hjpalpha]

While I agree that Captain & IGL aren't really staff roles, I also don't like showing them as additional badge on the right as we're tight on space there already. Let's say we have a longer name and we also have Stand-in/trophies/ loan team on the example above, we would run out of space.

Would it make sense to have a global icon for Captain and IGL and keep them on the left? In general, I think we should standardize it so if we have icon, show it, if not, don't show anything. @PiddyNydra thoughts?

an icon for those would be okay for me
fwiw the current/old TC on sc/sc2/sg already uses an icon for it:

but:

• it wouldn't solve the issue for other ingame roles that don't have an icon
• creating Module:PositionIcon/data would cause changes in transfers and TH/THA, so it would need to be set up outside of that module ...

[Eetwalt]

• it wouldn't solve the issue for other ingame roles that don't have an icon

What would be some cases that TCs currently support this that would break after migrating to TeamParticipants? Checked a couple cs tournaments and I can't find a case for AWPer displayed in TC but maybe I missed it

[hjpalpha]

• it wouldn't solve the issue for other ingame roles that don't have an icon

What would be some cases that TCs currently support this that would break after migrating to TeamParticipants? Checked a couple cs tournaments and I can't find a case for AWPer displayed in TC but maybe I missed it

not saying it is currently used (don't know if that is the case anywhere), but someone might potentially do in the future in TeamParticipants on new pages

[Eetwalt]

• it wouldn't solve the issue for other ingame roles that don't have an icon

What would be some cases that TCs currently support this that would break after migrating to TeamParticipants? Checked a couple cs tournaments and I can't find a case for AWPer displayed in TC but maybe I missed it

not saying it is currently used (don't know if that is the case anywhere), but someone might potentially do in the future in TeamParticipants on new pages

Ah, well at this point I would probably just not display roles that don't have icons at all, and figure out a nice design solution for such cases. Having in-game roles as icon on left and as text on the right feels a bit messy design to me

[hjpalpha]

• it wouldn't solve the issue for other ingame roles that don't have an icon

What would be some cases that TCs currently support this that would break after migrating to TeamParticipants? Checked a couple cs tournaments and I can't find a case for AWPer displayed in TC but maybe I missed it

not saying it is currently used (don't know if that is the case anywhere), but someone might potentially do in the future in TeamParticipants on new pages

Ah, well at this point I would probably just not display roles that don't have icons at all, and figure out a nice design solution for such cases. Having in-game roles as icon on left and as text on the right feels a bit messy design to me

okay for me (modulo igl captain), but would need to be implemented (it currently isn't) :P

[hjpalpha]

superseded by #7523 + #7529 + #7528