Skip to content

feat: TeamList conversion wrapper#7481

Open
hjpalpha wants to merge 23 commits into
mainfrom
hjpalpha-patch-2
Open

feat: TeamList conversion wrapper#7481
hjpalpha wants to merge 23 commits into
mainfrom
hjpalpha-patch-2

Conversation

@hjpalpha
Copy link
Copy Markdown
Collaborator

@hjpalpha hjpalpha commented May 10, 2026 •
edited
Loading

Summary

uses the existing modules Module:TeamList/Starcraft and Module:TeamList/Starcraft/TeamCard

  • removes display stuff from them
  • adds mapping from data the modules build to input params for new TP component
  • adds call to TP component with the mapped params
  • adds generator so that new TP wiki code can be pushed via subst bot run

Testing

dev (preview & storage & subst + revert)

Affected Wikis

  • stormgate: 8 pages
  • starcraft2: ~600 pages
  • starcraft: ~2k pages

Steps

  • Convert all Template:TeamList/Team calls to Template:TeamCard calls
  • Delete Template:TeamList/Team
  • Convert all usages of pure TeamCard calls (usually with box stuff arround them) to use TeamList wrapper (TeamCard already uses TeamList under the hood)
  • Clean up Toggle group start/Toggle group end usages in combi with TeamList
  • Write conversion wrapper (as dev of TeamList modules)
    • initial
    • test & debug
  • wait for necessary features of TeamParticipants for using wrapper
  • Inplace replace TeamList modules with the conversion wrapper (e.g. by merging this)
  • check / clean up tracking categories
    • Category:TeamList with br
    • Category:TeamList with notes
    • Category:TeamList with missing section title
    • Category:TeamList with dq opponent
  • wait for necessary features of TeamParticipants (for usage without wrapper)
  • start using TeamParticipants on new pages
  • Replace TeamCard and TeamList/Section usage with jsons (subst:#json:, TeamCard already does ecaxtly that when reaching this point, TeamList/Section only adds a single param (|type=section))
    • "\{\{teamcard" "{{subst:json:"
    • "\{\{teamlist/section" "{{subst:json:|type=section"
    • sc2
    • sg
    • bw
  • Delete Template:TeamCard on all 3 wikis & delete Template:TeamList/Section on commons
    • "\{\{teamlist" "{{subst:#invoke:Lua|invoke|module=TeamList/Starcraft|fn=TemplateTeamList|generate=1"
    • sc2
    • sg
    • bw
    • commons
  • If there are no issues mentioned within X months after inplace conversion start a (subst) replace run to use the option of the conversion wrapper to generate the wiki code
    • sc2
    • sg
    • bw
  • Archive/Delete the TeamList modules (i.e. the conversion wrappers) on commons and Template:TeamList on the 3 wikis
    • commons
    • sc2
    • sg
    • bw

@hjpalpha hjpalpha changed the title [Draft] Conversion of Template:TeamList feat: TeamList conversion wrapper May 12, 2026
hjpalpha
hjpalpha commented May 12, 2026
View reviewed changes
Comment thread lua/wikis/starcraft2/InGameRoles.lua Outdated
hjpalpha and others added 18 commits May 14, 2026 16:40
@hjpalpha
# This is a combination of 16 commits.
4f7ddcf 
# This is the 1st commit message:

Create TeamListConversion.md
# This is the commit message #2:

Update TeamListConversion.md
# This is the commit message #3:

Update TeamListConversion.md
# This is the commit message #4:

Update TeamListConversion.md
# This is the commit message #5:

Update TeamListConversion.md
# This is the commit message #6:

Update TeamListConversion.md
# This is the commit message #7:

Update TeamListConversion.md
# This is the commit message #8:

Update TeamListConversion.md
# This is the commit message #9:

Update TeamListConversion.md
# This is the commit message #10:

Update TeamListConversion.md
# This is the commit message #11:

Update TeamListConversion.md
# This is the commit message #12:

Update TeamListConversion.md
# This is the commit message #13:

Update TeamListConversion.md
# This is the commit message #14:

Update TeamListConversion.md
# This is the commit message #15:

Update TeamListConversion.md
# This is the commit message #16:

Update TeamListConversion.md
@hjpalpha
Create TeamListConversion.md
7976c3f 
Update TeamListConversion.md

Update TeamListConversion.md

Update TeamListConversion.md

Update TeamListConversion.md

Update TeamListConversion.md

Update TeamListConversion.md

Update TeamListConversion.md

Update TeamListConversion.md

Update TeamListConversion.md

Update TeamListConversion.md

Update TeamListConversion.md

Update TeamListConversion.md

Update TeamListConversion.md

Update TeamListConversion.md

Update TeamListConversion.md

Update TeamListConversion.md

some more
@hjpalpha
Update TeamCard.lua
e9b721b 
Update TeamCard.lua

Update Starcraft.lua
@hjpalpha
some window dressing
bdfdf1c
@hjpalpha
old params and their mapping to new ones
7f8bf49
@hjpalpha
another tracking category
ef984b2 
stfu warnings
@hjpalpha
start on the mapping
e5ebfa5 
rest of mapping (i hope)

remove mapping stuff from md as it is in the modules now
@hjpalpha
lets kick this
eef0c56
@hjpalpha
update the steps in the md
b9c05c2
@hjpalpha
fix todos & linter stuff
1f5b449
@hjpalpha
kick the md (moved to PR summary)
0c65bd0
@hjpalpha
shut up linter (i want to throw it away...)
85916b3
@hjpalpha
this seems better
d8473ef
@hjpalpha
deploy headers
2e4f75c
@hjpalpha
never import with the new stuff as it fucks things up
87bff66
@hjpalpha
a return is a good idea ...
5a79afe
@hjpalpha
sc2 ingame role ...
ccd6aac
@hjpalpha
stringify (so bools do not break the generator)
a52ac74
@hjpalpha hjpalpha force-pushed the hjpalpha-patch-2 branch from 55f649d to a52ac74 Compare May 14, 2026 14:43
@Eetwalt Eetwalt mentioned this pull request May 15, 2026
Open
75 tasks
@hjpalpha hjpalpha marked this pull request as ready for review May 19, 2026 11:28
@hjpalpha hjpalpha requested review from a team as code owners May 19, 2026 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

c: team_participant g: broodwar Starcraft: Brood War g: starcraft Starcraft g: stormgate Stormgate

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@hjpalpha