Skip to content

bug fix removing the assumption that primary key and sti column are defaults #684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
will3216 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

bug fix removing the assumption that primary key and sti column are defaults #684

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion lib/jsonapi/resource_serializer.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -306,7 +306,10 @@ def foreign_key_value(source, relationship)
def foreign_key_types_and_values(source, relationship)
if relationship.is_a?(JSONAPI::Relationship::ToMany)
if relationship.polymorphic?
source._model.public_send(relationship.name).pluck(:type, :id).map do |type, id|
relationship_model = relationship.options[:class_name].constantize
type_key = relationship_model.inheritance_column
id_key = relationship_model.primary_key
source._model.public_send(relationship.name).pluck(type_key.to_sym, id_key.to_sym).map do |type, id|
[type.underscore.pluralize, IdValueFormatter.format(id)]
end
else
Expand Down