bug fix removing the assumption that primary key and sti column are defaults#684
Open
will3216 wants to merge 1 commit intoJSONAPI-Resources:masterfrom
Open
Conversation
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I couldn't get the tests to run, but I don't have much time at the moment. This should solve any issues with people using non-standard inheritance_columns or non-standard primary keys, though I didn't have time to verify the latter.
If you pass me some info on test setup, I'll try and revisit this later today when I have some time to add relevant tests and whatnot. Also, let me know if you have any issues with how I bypassed the issue, I honestly did not put much thought into it, just needed to get myself unblocked >.<