feat(sandbox): support proposer pipelining in local network#23327
Open
spalladino wants to merge 2 commits into
Open
feat(sandbox): support proposer pipelining in local network#23327spalladino wants to merge 2 commits into
spalladino wants to merge 2 commits into
Conversation
ludamad
force-pushed
the
merge-train/spartan
branch
from
4af2626 to
db4ec58
Compare
ludamad
requested review from
IlyasRidhuan,
LHerskind,
Maddiaa0,
MirandaWood,
jeanmon and
just-mitch
as code owners
Prevents errors when simulating public calls in the node JSON RPC API that occur when simulating after a checkpoint has been closed but before the L2 slot is finished so the inbox is not yet sealed. See also A-1063
Second attempt This reverts commit 69f57fe.
spalladino
force-pushed
the
spl/sandbox-pipelining-v2
branch
from
d1b7e91 to
f2f8b57
Compare
spalladino
removed request for
LHerskind,
Maddiaa0,
MirandaWood,
jeanmon and
just-mitch
Collaborator
Flakey Tests🤖 says: This CI run detected 1 tests that failed, but were tolerated due to a .test_patterns.yml entry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Retrying #23313
The original PR failed due to timeout in docs/examples, which was caused by
aztecjs_advancedfailing repeatedely due to the bug fixed in 842887b which had been introduced in #23163. This PR brings the changes back from #23313, plus the simulation fix, plus an extra timeout to catch any other deviations since we were already pretty close to the 600s timeout before enabling pipelining.