Skip to content

fix(aztec-up): allow offline publish to local verdaccio#23376

Open
AztecBot wants to merge 1 commit into
merge-train/spartanfrom
cb/dd69e1f0bb2f
Open

fix(aztec-up): allow offline publish to local verdaccio#23376
AztecBot wants to merge 1 commit into
merge-train/spartanfrom
cb/dd69e1f0bb2f

Conversation

@AztecBot
Copy link
Copy Markdown
Collaborator

@AztecBot AztecBot commented May 18, 2026

aztec-up/bootstrap.sh spins up a local Verdaccio with proxy: npmjs on @*/* and **, then runs deploy_npm for each @aztec/*, @noir-lang/*, and @aztec/bb.js package. On publish, Verdaccio consults the npmjs uplink for existence/version checks; if the npmjs uplink is briefly unreachable, it returns 503 Service Unavailable - one of the uplinks is down, refuse to publish and the whole aztec-up-test-image build fails (e.g. #23327).

This is a "fake publish" path — we never actually consult npmjs for our own scoped packages, we just need verdaccio to accept the PUT. Verdaccio's publish.allow_offline opts into exactly that: publishes succeed when uplinks are unreachable.

Why this over enumerating namespaces in packages: without a proxy:

  • We publish @aztec/* (44 packages: @aztec/bb.js + 43 yarn-project workspaces) and @noir-lang/* (5: types, noir_js, noir_codegen, noirc_abi, acvm_js). A wildcard-per-namespace works today but silently breaks the day a new scope is added.
  • allow_offline: true is one line, namespace-agnostic, and only changes behaviour during the transient-failure case — the happy path still uses the uplink for normal validation and the ** proxy still primes transitive deps.

prep_test_mac already runs verdaccio with no uplinks at all (true offline) and is unaffected.


Created by claudebox · group: slackbot

@AztecBot AztecBot added the claudebox Owned by claudebox. it can push to this PR. label May 18, 2026
@spalladino spalladino changed the base branch from next to merge-train/spartan May 18, 2026 16:18
@spalladino spalladino marked this pull request as ready for review May 18, 2026 16:19
@spalladino spalladino requested a review from charlielye as a code owner May 18, 2026 16:19
@spalladino spalladino requested a review from alexghr May 18, 2026 16:19
@alexghr alexghr enabled auto-merge (squash) May 18, 2026 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

claudebox Owned by claudebox. it can push to this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants