Skip to content

fix: handle createClient rejection so isLoading resolves #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nicknisi wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −0
Open

fix: handle createClient rejection so isLoading resolves #97

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/provider.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,9 @@ export function AuthKitProvider(props: AuthKitProviderProps) {
getSignUpUrl: client.getSignUpUrl.bind(client),
});
setState((prev) => ({ ...prev, isLoading: false, user }));
})
.catch(() => {
setState((prev) => ({ ...prev, isLoading: false }));
});
Comment on lines +97 to 99
Copy link
Copy Markdown

@greptile-apps greptile-apps Bot May 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Silent error swallowing makes failures invisible

The .catch() handler discards the rejection entirely — no logging, no exposed error state. When createClient fails due to a misconfigured apiHostname, DNS error, or network timeout, the app silently moves to the unauthenticated state with zero diagnostic signal. In production this makes the root cause nearly impossible to identify without additional instrumentation.

});

Expand Down
Loading