Conversation
Carries the fix for [GHSA-c4rq-3m3g-8wgx][advisory] (high-severity ReDoS in Nokogiri's CSS selector tokenizer; vulnerable `< 1.19.3`). This repo is on `fastlane-plugin-wpmreleasetoolkit ~> 13.8`, which predates the toolkit's own `nokogiri >= 1.19.3` floor (added in 14.4.1). Pinning explicitly here closes the gap until a future toolkit-major bump makes the pin redundant. [advisory]: GHSA-c4rq-3m3g-8wgx --- Generated with the help of Claude Code, https://claude.com/claude-code Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
This PR mitigates GHSA-c4rq-3m3g-8wgx by ensuring the project resolves Nokogiri to a non-vulnerable version (>= 1.19.3), without requiring an upgrade of fastlane-plugin-wpmreleasetoolkit.
Changes:
- Add an explicit
nokogiri (>= 1.19.3)dependency to theGemfile. - Update
Gemfile.lockto resolvenokogirifrom1.19.1to1.19.3(including checksum and dependency list entry).
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| Gemfile | Adds explicit Nokogiri minimum version requirement and rationale comment. |
| Gemfile.lock | Updates resolved Nokogiri version and records it under dependencies/checksums. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| # Pinned to pull in the fix for GHSA-c4rq-3m3g-8wgx (CSS selector ReDoS). | ||
| # Drop once `fastlane-plugin-wpmreleasetoolkit` moves to >= 14.4.1, whose | ||
| # gemspec carries this floor transitively. | ||
| gem 'nokogiri', '>= 1.19.3' |
|
Holding this in draft. The CI failures here look like an infrastructure/cache-logic issue specific to this repo, not a problem with the lockfile bump:
trunk's recent CI is healthy (#2236 passed), so this is specific to my PR's interaction with the cache logic. Recipe is identical to the rest of the campaign: Once the CI cache logic is fixed (or someone with repo knowledge confirms the safe path), this PR can be re-monitored and merged. Posted by Claude Code (Opus 4.7) on behalf of @mokagio with approval. |
|
Closing in favor of #498 |
Note
Closed in favor of #498
Summary
Adds
gem 'nokogiri', '>= 1.19.3'toGemfileto pull in the fix for GHSA-c4rq-3m3g-8wgx — high-severity ReDoS in Nokogiri's CSS selector tokenizer (vulnerable< 1.19.3).This repo is on
fastlane-plugin-wpmreleasetoolkit ~> 13.8, which predates the toolkit's ownnokogiri >= 1.19.3floor (added in 14.4.1). The explicit pin closes the gap without requiring a release-toolkit major bump.Generated as part of the nokogiri 1.19.3 Orchard campaign.
Testing
bundle install.Gemfile.lockresolvesnokogirito1.19.3.Posted by Claude Code (Opus 4.7) on behalf of @mokagio with approval.