[ActionSheet] - Fix Android modal back dismiss#4005
Draft
MIchaelZablianov wants to merge 1 commit into
Draft
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
❌ PR Description Validation FailedThe following required sections need attention:
Required Sections:
Please update your PR description to include all required sections with meaningful content. This validation ensures all sections from the PR template are properly filled. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Description:
Solution:
Modal, but wrap it in a plain RNViewand create a fresh native modal instance for each open viamodalKey.onRequestClose, disable Android modal animation, and enable hardware acceleration.summary.mdwith the investigation notes, failed attempts, and the verified workaround.Changed Files:
demo/src/screens/componentScreens/ActionSheetScreen.tsx- adds the Android modal back-button workaround and modal comparison demo controls.summary.md- records findings for future work.Testing Changes:
yarn eslint "demo/src/screens/componentScreens/ActionSheetScreen.tsx" -c .eslintrc.js --ext .tsx.Breaking Changes:
Changelog:
ActionSheet- Fix Android back-button dismissal behavior in the React Native Modal demo.Made with Cursor