Skip to content

fix: add modalProps to Hint#4004

Open
omribz156 wants to merge 1 commit into
wix:masterfrom
omribz156:fix/hint-modal-props
Open

fix: add modalProps to Hint#4004
omribz156 wants to merge 1 commit into
wix:masterfrom
omribz156:fix/hint-modal-props

Conversation

@omribz156
Copy link
Copy Markdown

Description

Adds a modalProps prop to Hint and forwards it to the internal Modal when useModal is active. This lets callers pass React Native modal options such as supportedOrientations, which matches the use case in #3938.

Verification:

  • yarn workspace react-native-ui-lib test packages/react-native-ui-lib/src/components/hint/__tests__/index.spec.tsx
  • yarn build:dev
  • git diff --check

Note: the local Windows pre-push hook's full yarn lint --quiet run hit existing CRLF linebreak-style errors across unrelated checked-out files, so I pushed with --no-verify after the focused checks above passed.

This was implemented with Codex assistance, with the patch kept focused and manually reviewed before sending.

Changelog

Hint now supports modalProps, allowing additional props to be passed to the internal modal used by the component.

Additional info

Fixes #3938

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Modal props missing from Hint component

1 participant