feat: ASOBI_DB_SOCKET_OPTS=inet default for kura pool#38
Merged
Conversation
Pairs with widgrensit/asobi PR for env-controlled socket_options. Default inet keeps existing IPv4 deployments unchanged. On IPv6-only Postgres networks (Fly, certain k8s setups), override with ASOBI_DB_SOCKET_OPTS=inet6. Approved by asobi-architecture-guardian and erlang-code-reviewer.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
ENV ASOBI_DB_SOCKET_OPTS=inetto the Dockerfile and renders it into the kurasocket_optionslist inprod_sys.config.src. Pairs with widgrensit/asobi#113.Why
Default
inetkeeps existing IPv4 deployments unchanged. On IPv6-only Postgres networks (Fly Managed/Unmanaged Postgres on.flycast/.internal, certain k8s setups), override withASOBI_DB_SOCKET_OPTS=inet6.kura already reads
socket_optionsfrom app env (kura_app.erl:42-43), so this is purely a config exposure.Reviews
Test plan
[inet]in rendered sys.config)flyctl secrets set ASOBI_DB_SOCKET_OPTS=inet6→ kura pool connects to.flycastPostgres without sys.config patchinginet): unchanged behaviour, IPv4 connection to postgres containerRelated