Skip to content

fix: update blob/master to blob/main in base template manifest#2554

Merged
bpamiri merged 1 commit intodevelopfrom
peter/base-template-blob-main
May 11, 2026
Merged

fix: update blob/master to blob/main in base template manifest#2554
bpamiri merged 1 commit intodevelopfrom
peter/base-template-blob-main

Conversation

@bpamiri
Copy link
Copy Markdown
Collaborator

@bpamiri bpamiri commented May 11, 2026

Summary

  • The wheels-base-template ForgeBox package's license[].URL in tools/build/base/box.json still pointed at blob/master/LICENSE. The repo's default branch has been main since the v3.0 rebrand, so the link soft-404s on the ForgeBox package page.
  • PR #2546 fixed the same issue in the sister tools/build/core/box.json. Reviewer A flagged the base file as a pre-existing issue out of scope for that PR — this catches it.
  • No changelog field exists in this manifest; the LICENSE URL is the only blob/master/ reference.

Test plan

  • grep -n master tools/build/base/box.json returns nothing after the change
  • Next ForgeBox publish of wheels-base-template renders the license link as a working https://github.com/wheels-dev/wheels/blob/main/LICENSE

The wheels-base-template package's license URL on ForgeBox pointed at
the obsolete master branch, producing a soft 404. The default branch has
been main since the v3.0 rebrand. PR #2546 fixed the same issue in the
sister core template; this catches the base template that was flagged as
out of scope for that PR.
@github-actions github-actions Bot added the dependencies Pull requests that update a dependency file label May 11, 2026
Copy link
Copy Markdown
Contributor

@wheels-bot wheels-bot Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wheels Bot — Reviewer A

TL;DR: This is a clean, minimal one-line fix that updates the stale blob/master license URL in tools/build/base/box.json to blob/main, matching the default branch name since the v3.0 rebrand. The change is correct and the commit message is well-formed. Approving with one informational note about sibling files that have the same stale reference.


Correctness

The fix does exactly what the PR claims. The license URL in tools/build/base/box.json at line 47 now reads:

"URL":"https://github.com/wheels-dev/wheels/blob/main/LICENSE"

This mirrors the fix applied to tools/build/core/box.json in PR #2546 and resolves the soft-404 on the ForgeBox package page. No other blob/master references remain in either of the two tools/build/ manifests.

Nit — sibling examples/ manifests have the same stale reference

grep -rn "blob/master" examples/ turns up two more files that reference wheels-dev/wheels/blob/master/LICENSE:

  • examples/tweet/box.json line 48
  • examples/starter-app/box.json line 42

Neither is published to ForgeBox as actively as the base/core templates, but they will eventually produce the same soft-404 if they ever are. A follow-up PR updating them would be a tidy close-out. Not blocking — this PR's scope is correct as stated.

Commits

Single commit 1a20b917: fix: update blob/master to blob/main in base template manifest

  • Type fix — valid.
  • No scope — acceptable; no allowed scope maps cleanly to a ForgeBox manifest under tools/build/.
  • Subject is 53 characters, sentence-case, not ALL-CAPS.
  • Body explains the why (soft-404, v3.0 rebrand, companion to #2546) clearly.

All checks pass.

@wheels-bot
Copy link
Copy Markdown
Contributor

wheels-bot Bot commented May 11, 2026

Wheels Bot — Reviewer B (round 1)

A's review is substantively correct. The fix is a clean, verifiable one-line change, the commit is well-formed, and the approve verdict is appropriate. One gap: A's nit enumeration of stale blob/master references is incomplete, though this doesn't affect the verdict.

Sycophancy

None detected. A's approval is supported by explicit verification of the changed line and a commit message breakdown. No evidence-free LGTM.

False positives

None detected. I re-ran the greps A cited:

  • grep -rn "blob/master" tools/build/ returns nothing — confirms A's claim that the two tools/build/ manifests are now clean.
  • examples/tweet/box.json:48 and examples/starter-app/box.json:42 — both confirmed at the exact lines A cited.

Missed issues

A's nit enumeration is incomplete. The full blob/master footprint (outside vendor/ and .git/) includes five additional files A did not mention:

File Line Note
examples/tweet/app/snippets/BoxJSON.txt 44 Snippet template inside the tweet example
examples/starter-app/app/snippets/BoxJSON.txt 44 Double-stale: cfwheels/cfwheels/blob/master — old org name AND wrong branch
cli/src/templates/BoxJSON.txt 44 CLI scaffold template — affects every project created with wheels new
cli/lucli/templates/app/app/snippets/BoxJSON.txt 44 CLI scaffold template
app/snippets/BoxJSON.txt 44 App-level snippet template

The CLI template files (cli/src/templates/BoxJSON.txt, cli/lucli/templates/app/app/snippets/BoxJSON.txt) are the most impactful: every new project scaffolded via wheels new inherits the stale URL. None of these are in scope for this PR, and A correctly framed the nit as non-blocking follow-up work — but a complete enumeration would have surfaced the scaffold templates as higher priority than the example apps.

Verdict alignment

A's approve is consistent with the findings. This PR's scope is one file, the fix is correct, and the remaining stale references belong in a follow-up.

Convergence

Aligned. A's verdict and mine are both approve. The missed nit items are informational and do not warrant changes to this PR. Emitting converged-approve.

@bpamiri bpamiri merged commit 7d29a80 into develop May 11, 2026
7 checks passed
@bpamiri bpamiri deleted the peter/base-template-blob-main branch May 11, 2026 04:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant