Skip to content

Fixed clock rotate bug #501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Hamdyx wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fixed clock rotate bug #501

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 17 additions & 3 deletions 02 - JS and CSS Clock/index-FINISHED.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,20 +74,34 @@
const minsHand = document.querySelector('.min-hand');
const hourHand = document.querySelector('.hour-hand');

const transitionTxt = 'all 0.05s cubic-bezier(0.1, 2.7, 0.58, 1)';

function setDate() {
const now = new Date();

// @bug animation when rotate() resets from 450deg to 90deg
// element rotates unexpectedly before it comes back quickly to it's right position
const seconds = now.getSeconds();
const secondsDegrees = ((seconds / 60) * 360) + 90;
secondHand.style.transform = `rotate(${secondsDegrees}deg)`;
animateHand(seconds, secondHand, secondsDegrees);

const mins = now.getMinutes();
const minsDegrees = ((mins / 60) * 360) + ((seconds/60)*6) + 90;
minsHand.style.transform = `rotate(${minsDegrees}deg)`;
animateHand(mins, minsHand, minsDegrees);

const hour = now.getHours();
const hourDegrees = ((hour / 12) * 360) + ((mins/60)*30) + 90;
hourHand.style.transform = `rotate(${hourDegrees}deg)`;
animateHand(hour, hourHand, hourDegrees);
}

function animateHand(time, hand, degree) {
// @fix remove transition @ time = 0 before degree resets from 450 to 90
if (time === 0) {
hand.style.transition = 'none';
} else {
hand.style.transition = transitionTxt;
}
hand.style.transform = `rotate(${degree}deg)`;
}

setInterval(setDate, 1000);
Expand Down