fix(ci): diagnostic - bump sample app webex SDK#681
fix(ci): diagnostic - bump sample app webex SDK#681eigengravy wants to merge 2 commits intowebex:nextfrom
Conversation
Diagnostic test PR to verify whether CI cancellations on webex#665 are branch-specific or a wider infra/workflow issue.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0874217888
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| "ts-loader": "^9.5.1", | ||
| "typescript": "^5.6.3", | ||
| "webex": "3.11.0-next.50", | ||
| "webex": "3.12.0", |
There was a problem hiding this comment.
Update lockfile for the Webex SDK version bump
This change updates samples-cc-react-app to webex: "3.12.0" but does not update yarn.lock, which still resolves that workspace dependency to webex@npm:3.11.0-next.50. Because CI cache keys are derived from hashFiles('./yarn.lock') in .github/workflows/pull-request.yml, the cache key stays unchanged and downstream jobs can continue restoring node_modules built with the old SDK, so this commit may not actually test the new SDK version and can also fail immutable installs in workflows that enforce lockfile consistency.
Useful? React with 👍 / 👎.
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
Summary
Diagnostic / test-only PR. Do not merge.
Opened to verify whether the CI cancellations seen on #665 are branch-specific or reflect a broader infra/workflow issue. The only change is a one-line webex SDK version bump (
3.11.0-next.50→3.12.0) in the react sample app.Previous attempt (#680) was closed because the PR title didn't match the conventional-commit validator; retitled to
fix(ci): ....Test plan