Skip to content

fix(hud): restore click-through at original bar position after drag#542

Open
Reedaaz wants to merge 1 commit into
webadderallorg:mainfrom
Reedaaz:pr/fix-floating-bar-passthrough
Open

fix(hud): restore click-through at original bar position after drag#542
Reedaaz wants to merge 1 commit into
webadderallorg:mainfrom
Reedaaz:pr/fix-floating-bar-passthrough

Conversation

@Reedaaz
Copy link
Copy Markdown

@Reedaaz Reedaaz commented May 20, 2026

Fixes #535

Problem

The HUD overlay wrapper kept pointer-events: auto at its layout-original position. When the floating bar is dragged, only the inner hudBarTransformRef div shifts visually via CSS translate3d — the outer wrapper stays put. Any mouseenter on that stale area still triggers handleHudMouseEntersetIgnoreMouseEvents(false) on the full-screen HUD window, which then swallows clicks intended for the underlying app (Excel, browser, etc.).

Fix

Move pointer-events: auto and the mouse enter/leave handlers from the static wrapper onto the transformed hudBarTransformRef div, so the interactive hit area follows the bar's actual rendered position.

Test plan

  • Open Excel (or any app), start recording
  • Drag the floating bar to a new location
  • Click on a cell at the bar's original position → click reaches Excel correctly
  • Click on a button on the bar at its new position → bar still interactive
  • Webcam preview continues to receive its own pointer events (separate sibling with own handlers)

Summary by CodeRabbit

  • Bug Fixes
    • Improved mouse hover interaction responsiveness on the HUD bar by restructuring pointer event handling to better target interactive elements.

Review Change Stack

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 20, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 6762381c-ade8-43ab-843a-651352d4bc46

📥 Commits

Reviewing files that changed from the base of the PR and between 4f729b7 and 3550bdd.

📒 Files selected for processing (1)
  • src/components/launch/LaunchWindow.tsx

📝 Walkthrough

Walkthrough

The HUD bar wrapper structure in LaunchWindow.tsx is refactored to shift pointer-event handling. The outer container now uses pointer-events-none while the inner element with hudBarTransformRef uses pointer-events-auto and receives the onMouseEnter/onMouseLeave event handlers, relocating interactive targets to the transformed element.

Changes

HUD wrapper pointer-events handling

Layer / File(s) Summary
HUD wrapper pointer-events restructuring
src/components/launch/LaunchWindow.tsx
The outer HUD container becomes pointer-events-none while the inner transformed element with hudBarTransformRef becomes pointer-events-auto and receives the mouse hover event handlers.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~15 minutes

Possibly related PRs

  • webadderallorg/Recordly#163: Both PRs modify LaunchWindow.tsx pointer and mouse handling for HUD interactions, with overlapping changes to mouse-leave behavior and pointer-events configuration.
  • webadderallorg/Recordly#486: Both PRs adjust HUD mouse-event and hover handling, with this PR moving hover hit-testing via pointer-events restructuring while the related PR uses these targets for Windows mouse passthrough detection.

Suggested labels

Checked

Poem

🐰 A pointer event hops left, then right,
The outer fades to ghostly night,
The inner glows with touch so keen—
Best hover dance you've ever seen!

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically summarizes the main fix: restoring click-through functionality at the original bar position after dragging, which directly matches the PR's core problem and solution.
Description check ✅ Passed The description provides clear problem statement, fix explanation, and comprehensive test plan, though it deviates from the template format by using custom sections instead of the required template structure.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

ESLint skipped: no ESLint configuration detected in root package.json. To enable, add eslint to devDependencies.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Item under floating bar not click-able

1 participant