NFC-158 Deprecations removal and using prettier#54
Open
SanderKondratjevNortal wants to merge 2 commits intoweb-eid-mobilefrom
Open
NFC-158 Deprecations removal and using prettier#54SanderKondratjevNortal wants to merge 2 commits intoweb-eid-mobilefrom
SanderKondratjevNortal wants to merge 2 commits intoweb-eid-mobilefrom
Conversation
Signed-off-by: Sander Kondratjev <sander.kondratjev@nortal.com>
Signed-off-by: Sander Kondratjev <sander.kondratjev@nortal.com>
mrts
requested changes
Apr 27, 2026
| "psr/log": "^3.0.0" | ||
| }, | ||
| "scripts": { | ||
| "fix-php": ["prettier src/**/* --write", "prettier examples/src/* --write"], |
Member
There was a problem hiding this comment.
Prettier remained here. Either remove or replace with phpcbf:
Suggested change
| "fix-php": ["./vendor/bin/phpcbf"], |
| @@ -1 +1 @@ | |||
| { | |||
Member
There was a problem hiding this comment.
To assure format stays correct in the future, let's add ./vendor/bin/phpcs to .github/workflows/php.yml.
mrts
reviewed
Apr 27, 2026
| <arg name="colors"/> | ||
| <arg value="p"/> | ||
|
|
||
| <rule ref="PSR12"> |
Member
There was a problem hiding this comment.
Let's limit the rules to the specific files:
<rule ref="PSR1.Classes.ClassDeclaration.MultipleClasses">
<exclude-pattern>src/util/CollectionsUtil.php</exclude-pattern>
</rule>
<rule ref="PSR1.Classes.ClassDeclaration.MissingNamespace">
<exclude-pattern>example/src/*</exclude-pattern>
</rule>
<rule ref="PSR1.Methods.CamelCapsMethodName.NotCamelCaps">
<exclude-pattern>tests/*</exclude-pattern>
</rule>
<rule ref="Generic.Files.LineLength.TooLong">
<exclude-pattern>tests/*</exclude-pattern>
</rule>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Sander Kondratjev Sander.Kondratjev@Nortal.com