Add resilient OCSP certificate revocation checker#99
Open
madislm wants to merge 1 commit intoweb-eid:WE2-1030-use-platform-ocspfrom
Open
Add resilient OCSP certificate revocation checker#99madislm wants to merge 1 commit intoweb-eid:WE2-1030-use-platform-ocspfrom
madislm wants to merge 1 commit intoweb-eid:WE2-1030-use-platform-ocspfrom
Conversation
madislm
force-pushed
the
AUT-2514
branch
2 times, most recently
from
0e6161a to
e927de2
Compare
madislm
force-pushed
the
AUT-2514
branch
5 times, most recently
from
e96286a to
a324e96
Compare
mrts
force-pushed
the
WE2-1030-use-platform-ocsp
branch
from
10a405b to
74e7af2
Compare
madislm
force-pushed
the
AUT-2514
branch
2 times, most recently
from
9cdcc89 to
ef4ae35
Compare
mrts
force-pushed
the
WE2-1030-use-platform-ocsp
branch
from
74e7af2 to
f55d636
Compare
mrts
requested changes
Mar 20, 2026
mrts
reviewed
Mar 20, 2026
mrts
requested changes
Apr 14, 2026
mrts
requested changes
Apr 24, 2026
madislm
force-pushed
the
AUT-2514
branch
6 times, most recently
from
83ff528 to
b4d8d06
Compare
mrts
approved these changes
Apr 27, 2026
mrts
requested changes
Apr 27, 2026
| public List<RevocationInfo> validateCertificateNotRevoked(X509Certificate subjectCertificate, | ||
| X509Certificate issuerCertificate) throws AuthTokenException { | ||
| OcspService primaryService = resolvePrimaryOcspService(subjectCertificate); | ||
| CircuitBreaker circuitBreaker = circuitBreakerRegistry.circuitBreaker(primaryService.getAccessLocation().toASCIIString()); |
Member
There was a problem hiding this comment.
If fallback service is not present, this creates an unused circuit breaker object, which is redundant and slightly misleading. This should be moved after line 123.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AUT-2514
Signed-off-by: Madis Jaagup Laurson madisjaagup.laurson@nortal.com