fix(cli) Add Mistral Vibe to recognized CLI agents#9722
fix(cli) Add Mistral Vibe to recognized CLI agents#9722doubledare704 wants to merge 1 commit intowarpdotdev:masterfrom
Conversation
|
I'm starting a first review of this pull request. You can view the conversation on Warp. I completed the review and posted feedback on this pull request. Comment Powered by Oz |
There was a problem hiding this comment.
Overview
This PR adds Mistral Vibe as a recognized CLI agent, including detection, display metadata, telemetry mapping, rich-input submission behavior, and structured session listener support.
Concerns
- [IMPORTANT]
CLIAgent::Vibedefines a brand-colored avatar background but returns no icon, so the generic fallback icon uses themesub_textrather than a contrast-safe foreground for the orange background. - [IMPORTANT] This is user-visible because it changes the displayed agent name/color and CLI agent UI behavior, but the PR includes no screenshot or video. For faster review, please upload screenshots or a video of the feature working end to end.
Verdict
Found: 0 critical, 2 important, 0 suggestions
Request changes
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
| CLIAgent::Pi => Some(Icon::PiLogo), | ||
| CLIAgent::Auggie => Some(Icon::AuggieLogo), | ||
| CLIAgent::CursorCli => Some(Icon::CursorLogo), | ||
| CLIAgent::Vibe => None, |
There was a problem hiding this comment.
None makes Vibe use the generic terminal icon, which is colored with theme sub_text while the avatar background is MISTRAL_ORANGE; add a Vibe icon or update the fallback so branded agents without icons use a contrast-safe foreground.
Description
Adds Mistral Vibe as a recognized CLI agent so Warp can detect
vibe, display the correct agent name and brand color, route telemetry with a dedicated CLI agent type, and handle structured CLI agent session events.Also adds focused test coverage for Vibe command detection, brand color, and session listener support.
Linked Issue
Closes #9607
ready-to-specorready-to-implement.Screenshots / Videos
N/A
Testing
cargo test -p warp vibecargo test -p warp test_detect_known_agentscargo nextestwas not installed locally, so focused coverage was verified withcargo test.Agent Mode