Skip to content

fix(cli) Add Mistral Vibe to recognized CLI agents#9722

Open
doubledare704 wants to merge 1 commit intowarpdotdev:masterfrom
doubledare704:feat/implement-mistral-vibe-changes
Open

fix(cli) Add Mistral Vibe to recognized CLI agents#9722
doubledare704 wants to merge 1 commit intowarpdotdev:masterfrom
doubledare704:feat/implement-mistral-vibe-changes

Conversation

@doubledare704
Copy link
Copy Markdown

Description

Adds Mistral Vibe as a recognized CLI agent so Warp can detect vibe, display the correct agent name and brand color, route telemetry with a dedicated CLI agent type, and handle structured CLI agent session events.

Also adds focused test coverage for Vibe command detection, brand color, and session listener support.

Linked Issue

Closes #9607

  • The linked issue is labeled ready-to-spec or ready-to-implement.
  • Where appropriate, screenshots or a short video of the implementation are included below (especially for user-visible or UI changes).

Screenshots / Videos

N/A

Testing

  • cargo test -p warp vibe
  • cargo test -p warp test_detect_known_agents

cargo nextest was not installed locally, so focused coverage was verified with cargo test.

Agent Mode

  • Warp Agent Mode - This PR was created via Warp's AI Agent Mode

@cla-bot cla-bot Bot added the cla-signed label May 1, 2026
@oz-for-oss
Copy link
Copy Markdown
Contributor

oz-for-oss Bot commented May 1, 2026

@doubledare704

I'm starting a first review of this pull request.

You can view the conversation on Warp.

I completed the review and posted feedback on this pull request.

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

@github-actions github-actions Bot added the external-contributor Indicates that a PR has been opened by someone outside the Warp team. label May 1, 2026
Copy link
Copy Markdown
Contributor

@oz-for-oss oz-for-oss Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overview

This PR adds Mistral Vibe as a recognized CLI agent, including detection, display metadata, telemetry mapping, rich-input submission behavior, and structured session listener support.

Concerns

  • [IMPORTANT] CLIAgent::Vibe defines a brand-colored avatar background but returns no icon, so the generic fallback icon uses theme sub_text rather than a contrast-safe foreground for the orange background.
  • [IMPORTANT] This is user-visible because it changes the displayed agent name/color and CLI agent UI behavior, but the PR includes no screenshot or video. For faster review, please upload screenshots or a video of the feature working end to end.

Verdict

Found: 0 critical, 2 important, 0 suggestions

Request changes

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

CLIAgent::Pi => Some(Icon::PiLogo),
CLIAgent::Auggie => Some(Icon::AuggieLogo),
CLIAgent::CursorCli => Some(Icon::CursorLogo),
CLIAgent::Vibe => None,
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [IMPORTANT] Returning None makes Vibe use the generic terminal icon, which is colored with theme sub_text while the avatar background is MISTRAL_ORANGE; add a Vibe icon or update the fallback so branded agents without icons use a contrast-safe foreground.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed external-contributor Indicates that a PR has been opened by someone outside the Warp team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Mistral Vibe to recognized CLI agents

1 participant