fix(cli):Support Pi CLI agent notifications#9720
fix(cli):Support Pi CLI agent notifications#9720doubledare704 wants to merge 1 commit intowarpdotdev:masterfrom
Conversation
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @doubledare704 on file. In order for us to review and merge your code, each contributor must visit https://cla.warp.dev to read and agree to our CLA. Once you have done so, please comment |
|
I'm starting a first review of this pull request. You can view the conversation on Warp. I reviewed this pull request and requested human review from: @zachbai. Comment Powered by Oz |
There was a problem hiding this comment.
Overview
This PR enables CLIAgent::Pi in the CLI agent session listener by marking it supported and routing it through the default structured OSC 777 listener path, with unit coverage for support/rich-status behavior and default event filtering.
Concerns
- No blocking concerns found.
- Supplemental security pass: no security concerns found in the changed listener wiring or tests.
Verdict
Found: 0 critical, 0 important, 0 suggestions
Approve
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
Description
Added support for
CLIAgent::Piin the CLI agent session listener so Pi notifications are handled by the default structured event listener instead of being dropped. This makes Pi behave like the other supported structured OSC 777 agents and ensures its session events can surface in the UI.Linked Issue
ready-to-specorready-to-implement.Closes #9663
Screenshots / Videos
Not applicable. This is a backend/session-listener behavior change with no direct UI surface.
Testing
Added unit tests in
app/src/terminal/cli_agent_sessions/listener/mod.rscovering:SessionStartStopVerified with:
cargo test -p warp cli_agent_sessions::listener::tests::