Skip to content

fix(cli):Support Pi CLI agent notifications#9720

Open
doubledare704 wants to merge 1 commit intowarpdotdev:masterfrom
doubledare704:feat/9663-pi-cli-agent-listener-tests
Open

fix(cli):Support Pi CLI agent notifications#9720
doubledare704 wants to merge 1 commit intowarpdotdev:masterfrom
doubledare704:feat/9663-pi-cli-agent-listener-tests

Conversation

@doubledare704
Copy link
Copy Markdown

Description

Added support for CLIAgent::Pi in the CLI agent session listener so Pi notifications are handled by the default structured event listener instead of being dropped. This makes Pi behave like the other supported structured OSC 777 agents and ensures its session events can surface in the UI.

Linked Issue

  • The linked issue is labeled ready-to-spec or ready-to-implement.
  • Where appropriate, screenshots or a short video of the implementation are included below (especially for user-visible or UI changes).

Closes #9663

Screenshots / Videos

Not applicable. This is a backend/session-listener behavior change with no direct UI surface.

Testing

Added unit tests in app/src/terminal/cli_agent_sessions/listener/mod.rs covering:

  • Pi is reported as supported
  • Pi uses the default listener with rich status
  • Pi default listener skips SessionStart
  • Pi default listener forwards Stop

Verified with:

cargo test -p warp cli_agent_sessions::listener::tests::

@cla-bot
Copy link
Copy Markdown

cla-bot Bot commented May 1, 2026

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @doubledare704 on file. In order for us to review and merge your code, each contributor must visit https://cla.warp.dev to read and agree to our CLA. Once you have done so, please comment @cla-bot check to trigger another check.

@github-actions github-actions Bot added the external-contributor Indicates that a PR has been opened by someone outside the Warp team. label May 1, 2026
@oz-for-oss
Copy link
Copy Markdown
Contributor

oz-for-oss Bot commented May 1, 2026

@doubledare704

I'm starting a first review of this pull request.

You can view the conversation on Warp.

I reviewed this pull request and requested human review from: @zachbai.

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

@doubledare704 doubledare704 changed the title Support Pi CLI agent notifications fix(cli):Support Pi CLI agent notifications May 1, 2026
Copy link
Copy Markdown
Contributor

@oz-for-oss oz-for-oss Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overview

This PR enables CLIAgent::Pi in the CLI agent session listener by marking it supported and routing it through the default structured OSC 777 listener path, with unit coverage for support/rich-status behavior and default event filtering.

Concerns

  • No blocking concerns found.
  • Supplemental security pass: no security concerns found in the changed listener wiring or tests.

Verdict

Found: 0 critical, 0 important, 0 suggestions

Approve

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

@oz-for-oss oz-for-oss Bot requested a review from zachbai May 1, 2026 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

external-contributor Indicates that a PR has been opened by someone outside the Warp team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CLIAgent::Pi is dropped at the listener — no toasts for Pi today

1 participant