Conversation
Bumps phpstan/phpstan from 1.* to ^2.0 and fixes the 3 errors surfaced at level 5: - curl_setopt CURLOPT_RETURNTRANSFER value uses bool instead of int - drop redundant assertIsArray/assertIsInt on already-typed returns Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Greptile SummaryUpgrades PHPStan from Confidence Score: 5/5Safe to merge — straightforward dev-dependency upgrade with only test and lint fixes. All changes are confined to dev dependencies and test files; no production logic was modified. The three fixes are correct responses to PHPStan 2.x diagnostics. No files require special attention. Important Files Changed
Reviews (1): Last reviewed commit: "Chore: Upgrade PHPStan to 2.x" | Re-trigger Greptile |
k6 benchmark
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
phpstan/phpstanfrom1.*to^2.0(installed 2.1.51)tests/e2e/Client.php: passtruetocurl_setopt(..., CURLOPT_RETURNTRANSFER, ...)(param isbool, notint)tests/RequestTest.php: drop redundantassertIsArray/assertIsInton already-typed returns (method.alreadyNarrowedType)Level stays at 5.
Test plan
composer analyzepassescomposer testpasses🤖 Generated with Claude Code